| Message ID | 20230314131718.27031-1-alfredo.carlon@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | clk/tegra/clk-tegra124-dfll-fcpu: Add check to 'regulator_list_voltage' | expand |
Quoting Alfredo Cruz (2023-03-14 06:17:18) > Signed-off-by: Alfredo Cruz <alfredo.carlon@gmail.com> Sorry, we can't apply this. It needs commit text. Please see Documentation/process/submitting-patches.rst > --- > Hi, > I'm not entirely sure if 'regulator_list_voltage(reg, 0)' will never return less than 0. Please find out.
diff --git a/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c b/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c index 5e339ad0a97c..745bb828e53e 100644 --- a/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c +++ b/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c @@ -543,6 +543,8 @@ static int get_alignment_from_regulator(struct device *dev, return PTR_ERR(reg); align->offset_uv = regulator_list_voltage(reg, 0); + if (align->offset_uv < 0) + align->offset_uv = 0; align->step_uv = regulator_get_linear_step(reg); regulator_put(reg);
Signed-off-by: Alfredo Cruz <alfredo.carlon@gmail.com> --- Hi, I'm not entirely sure if 'regulator_list_voltage(reg, 0)' will never return less than 0. drivers/clk/tegra/clk-tegra124-dfll-fcpu.c | 2 ++ 1 file changed, 2 insertions(+)