| Message ID | 20220523152811.19692-1-linmq006@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | clk: tegra20: Fix refcount leak in tegra20_clock_init | expand |
Quoting Miaoqian Lin (2022-05-23 08:28:11) > of_find_matching_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 37c26a906527 ("clk: tegra: add clock support for Tegra20") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > --- Applied to clk-next
diff --git a/drivers/clk/tegra/clk-tegra20.c b/drivers/clk/tegra/clk-tegra20.c index be3c33441cfc..8a4514f6d503 100644 --- a/drivers/clk/tegra/clk-tegra20.c +++ b/drivers/clk/tegra/clk-tegra20.c @@ -1131,6 +1131,7 @@ static void __init tegra20_clock_init(struct device_node *np) } pmc_base = of_iomap(node, 0); + of_node_put(node); if (!pmc_base) { pr_err("Can't map pmc registers\n"); BUG();
of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 37c26a906527 ("clk: tegra: add clock support for Tegra20") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/clk/tegra/clk-tegra20.c | 1 + 1 file changed, 1 insertion(+)