diff mbox series

[v1,1/1] arm64: tegra194: p2888: Correct interrupt trigger type of temperature sensor

Message ID 20210711234939.28103-2-digetx@gmail.com
State Superseded
Headers show
Series Tegra ARM64 device-tree improvements for 5.15 | expand

Commit Message

Dmitry Osipenko July 11, 2021, 11:49 p.m. UTC 
The LM90 temperature sensor should use edge-triggered interrupt because
LM90 hardware doesn't deassert interrupt line until temperature is back
to normal state, which results in interrupt storm. Correct the interrupt
trigger type.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thierry Reding Aug. 11, 2021, 10:10 a.m. UTC | #1 
On Mon, Jul 12, 2021 at 02:49:39AM +0300, Dmitry Osipenko wrote:
> The LM90 temperature sensor should use edge-triggered interrupt because
> LM90 hardware doesn't deassert interrupt line until temperature is back
> to normal state, which results in interrupt storm. Correct the interrupt
> trigger type.
> 
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thierry
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
index 7e7b0eb90c80..c4058ee36fec 100644
--- a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
@@ -309,7 +309,7 @@  temperature-sensor@4c {
 
 				interrupt-parent = <&gpio>;
 				interrupts = <TEGRA194_MAIN_GPIO(H, 2)
-					      IRQ_TYPE_LEVEL_LOW>;
+					      IRQ_TYPE_EDGE_FALLING>;
 				vcc-supply = <&vdd_1v8ls>;
 
 				#thermal-sensor-cells = <1>;