From patchwork Sun May 23 22:42:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 1482546 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=OWa/a3oT; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4FpFkL18v7z9s1l for ; Mon, 24 May 2021 08:43:38 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232005AbhEWWpA (ORCPT ); Sun, 23 May 2021 18:45:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231976AbhEWWo7 (ORCPT ); Sun, 23 May 2021 18:44:59 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 847CBC061756; Sun, 23 May 2021 15:43:18 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id a2so37886824lfc.9; Sun, 23 May 2021 15:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QrbZfFAlvahMlx2onf5N7LsOj4l18BaiDKGnlBtkUuo=; b=OWa/a3oTJOeZTJ1gaWteSVnJYSFONENuIwT6gwmObr0C3fzXioVbeQsWkd5DKB3gkW eu+/ARObHPs0MkXOrkkgRjMkf9RtauGoFbk2yRWYnDcfRrzTtbiSXzZ3cowj7uIdrzmG lazRgl9LhtP2eTOREu+YM1L067X9eL87ItrrwHw0Zk4RRF3IhguRBcvehmKxxFk0zm/u Nr2A1O5ER33vi8yC1dxdHSkGWILHJdS6YXp8J8lN21651goSRkTnFdhzjRX55NNiWF4I V2fXQpDnFPPr7Vo47xu/xeib1d0wnevrK3DUYAWjH7gdIFLIBILiEIv1uHdmKMDDoBbi PhyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QrbZfFAlvahMlx2onf5N7LsOj4l18BaiDKGnlBtkUuo=; b=sm6T2f6oi6rBIRU7zsadHPT8BX4br9rbQIjf3ZnsV8TJD4E7fhlzWZIvkAVMCDQMaS lAhD9AMeRNZTXcJhC4GCcTuqeKFeEswYIh5JXyPt0M813+io9cv4Xo820elqaT54Yf74 gSrujU0wkYS38/a28d++Cjg7mWm1klXR23W6xaxHaXDHVTU5yCsZ/5Ys9TiThCbhFOZa qO3pgaeuLCSlQpoedlHu5mnlK6VOU6Vqg/11hoyoJHVsoOAnPEDnY+GPOg6te6LiGGrA JPCk9drnULFryI/UOWmuxiN9tLFzmxRS23kU4RIl/tbRbhvF7QXq7e8rGEm0hpAojtH2 RmNg== X-Gm-Message-State: AOAM531cbMmQGtmlvsx1SG1B2sBN4WT6GU/exVZWUQWauGMfVfX4Fh0E Zugp0f9Mkof0mQCB7AEOkX4= X-Google-Smtp-Source: ABdhPJy4S8iKqd01bq5z3lxJ2k9xYpWLsCnubhbdlg2xNIUqjVw8rLY87d1NWuxLq6PdxwTY7G8o6g== X-Received: by 2002:a05:6512:3f08:: with SMTP id y8mr8835954lfa.657.1621809796856; Sun, 23 May 2021 15:43:16 -0700 (PDT) Received: from localhost.localdomain (109-252-193-110.dynamic.spd-mgts.ru. [109.252.193.110]) by smtp.gmail.com with ESMTPSA id m5sm1531622ljg.118.2021.05.23.15.43.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 May 2021 15:43:16 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Mark Brown , Liam Girdwood Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v1 1/2] regulator: max77620: Use device_set_of_node_from_dev() Date: Mon, 24 May 2021 01:42:42 +0300 Message-Id: <20210523224243.13219-2-digetx@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210523224243.13219-1-digetx@gmail.com> References: <20210523224243.13219-1-digetx@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org The MAX77620 driver fails to re-probe on deferred probe because driver core tries to claim resources that are already claimed by the PINCTRL device. Use device_set_of_node_from_dev() helper which marks OF node as reused, skipping erroneous execution of pinctrl_bind_pins() for the PMIC device on the re-probe. Fixes: aea6cb99703e ("regulator: resolve supply after creating regulator") Signed-off-by: Dmitry Osipenko --- drivers/regulator/max77620-regulator.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/regulator/max77620-regulator.c b/drivers/regulator/max77620-regulator.c index 8d9731e4052b..5c439c850d09 100644 --- a/drivers/regulator/max77620-regulator.c +++ b/drivers/regulator/max77620-regulator.c @@ -814,6 +814,13 @@ static int max77620_regulator_probe(struct platform_device *pdev) config.dev = dev; config.driver_data = pmic; + /* + * Set of_node_reuse flag to prevent driver core from attempting to + * claim any pinmux resources already claimed by the parent device. + * Otherwise PMIC driver will fail to re-probe. + */ + device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent); + for (id = 0; id < MAX77620_NUM_REGS; id++) { struct regulator_dev *rdev; struct regulator_desc *rdesc;