| Message ID | 20210326145139.467072-2-thierry.reding@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | drm/tegra: Various improvements | expand |
LGTM, thanks!
Reviewed-by: Simon Ser <contact@emersion.fr>
Let me know if you need me to push this to drm-misc-next.
On Fri, Mar 26, 2021 at 02:54:22PM +0000, Simon Ser wrote: > LGTM, thanks! > > Reviewed-by: Simon Ser <contact@emersion.fr> > > Let me know if you need me to push this to drm-misc-next. I do have commit access for drm-misc-next, but I was thinking that I could take this through the drm/tegra tree along with the subsequent patches because of the dependency. Anyone willing to provide an Acked-by for that? Thierry
Hi Thierry, On Tue, 27 Apr 2021 at 19:40, Daniel Stone <daniel@fooishbar.org> wrote: > On Fri, 26 Mar 2021 at 16:29, Thierry Reding <thierry.reding@gmail.com> wrote: >> On Fri, Mar 26, 2021 at 02:54:22PM +0000, Simon Ser wrote: >> > LGTM, thanks! >> > >> > Reviewed-by: Simon Ser <contact@emersion.fr> >> > >> > Let me know if you need me to push this to drm-misc-next. >> >> I do have commit access for drm-misc-next, but I was thinking that I >> could take this through the drm/tegra tree along with the subsequent >> patches because of the dependency. >> >> Anyone willing to provide an Acked-by for that? > > Yep, no harm if that makes your life easier, so for both the patch itself and merging through tegra: > Acked-by: Daniel Stone <daniels@collabora.com> Is this still in your queue somewhere? Cheers, Daniel
On Wed, Jun 09, 2021 at 05:28:50PM +0100, Daniel Stone wrote: > Hi Thierry, > > On Tue, 27 Apr 2021 at 19:40, Daniel Stone <daniel@fooishbar.org> wrote: > > On Fri, 26 Mar 2021 at 16:29, Thierry Reding <thierry.reding@gmail.com> wrote: > >> On Fri, Mar 26, 2021 at 02:54:22PM +0000, Simon Ser wrote: > >> > LGTM, thanks! > >> > > >> > Reviewed-by: Simon Ser <contact@emersion.fr> > >> > > >> > Let me know if you need me to push this to drm-misc-next. > >> > >> I do have commit access for drm-misc-next, but I was thinking that I > >> could take this through the drm/tegra tree along with the subsequent > >> patches because of the dependency. > >> > >> Anyone willing to provide an Acked-by for that? > > > > Yep, no harm if that makes your life easier, so for both the patch itself and merging through tegra: > > Acked-by: Daniel Stone <daniels@collabora.com> > > Is this still in your queue somewhere? I reverted to an open-coded version at the time because the -rc6 cut-off was coming up quickly and I wasn't getting a response. But I do have a set of follow-up patches in a branch somewhere that convert the existing users to the new helpers. Let me dig those out and send them out again. Thierry
On Thu, 10 Jun 2021 at 09:56, Thierry Reding <thierry.reding@gmail.com> wrote: > On Wed, Jun 09, 2021 at 05:28:50PM +0100, Daniel Stone wrote: > > On Tue, 27 Apr 2021 at 19:40, Daniel Stone <daniel@fooishbar.org> wrote: > > > On Fri, 26 Mar 2021 at 16:29, Thierry Reding <thierry.reding@gmail.com> wrote: > > >> I do have commit access for drm-misc-next, but I was thinking that I > > >> could take this through the drm/tegra tree along with the subsequent > > >> patches because of the dependency. > > >> > > >> Anyone willing to provide an Acked-by for that? > > > > > > Yep, no harm if that makes your life easier, so for both the patch itself and merging through tegra: > > > Acked-by: Daniel Stone <daniels@collabora.com> > > > > Is this still in your queue somewhere? > > I reverted to an open-coded version at the time because the -rc6 cut-off > was coming up quickly and I wasn't getting a response. But I do have a > set of follow-up patches in a branch somewhere that convert the existing > users to the new helpers. > > Let me dig those out and send them out again. OK, I didn't realise this had been dropped from your queue. That sounds reasonable, and we'll just open-code as well in libdrm for the moment, since we want to have the modifier-name API in without having to wait another few months ... Cheers, Daniel
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index f76de49c768f..64f01bc2624c 100644 --- a/include/uapi/drm/drm_fourcc.h +++ b/include/uapi/drm/drm_fourcc.h @@ -366,6 +366,12 @@ extern "C" { #define DRM_FORMAT_RESERVED ((1ULL << 56) - 1) +#define fourcc_mod_get_vendor(modifier) \ + (((modifier) >> 56) & 0xff) + +#define fourcc_mod_is_vendor(modifier, vendor) \ + (fourcc_mod_get_vendor(modifier) == DRM_FORMAT_MOD_VENDOR_## vendor) + #define fourcc_mod_code(vendor, val) \ ((((__u64)DRM_FORMAT_MOD_VENDOR_## vendor) << 56) | ((val) & 0x00ffffffffffffffULL))