| Message ID | 20210320151915.7566-2-digetx@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v1,1/2] ARM: multi_v7_defconfig: Stop using deprecated USB_EHCI_TEGRA | expand |
On Sat, Mar 20, 2021 at 06:19:15PM +0300, Dmitry Osipenko wrote: > Select USB_GADGET Kconfig option in order to fix build failure which > happens because ChipIdea driver has a build dependency on both USB_GADGET > and USB_EHCI_HCD, while USB_EHCI_TEGRA force-selects the ChipIdea driver > without taking into account the tristate USB_GADGET dependency. It's not > possible to do anything about the cyclic dependency of the Kconfig > options, but USB_EHCI_TEGRA is now a deprecated option that isn't used > by defconfigs and USB_GADGET is wanted on Tegra by default, hence it's > okay to have a bit clunky workaround for it. > > Fixes: c3590c7656fb ("usb: host: ehci-tegra: Remove the driver") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> Acked-by: Alan Stern <stern@rowland.harvard.edu> > --- > drivers/usb/host/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > index b94f2a070c05..df9428f1dc5e 100644 > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/Kconfig > @@ -272,6 +272,7 @@ config USB_EHCI_TEGRA > select USB_CHIPIDEA > select USB_CHIPIDEA_HOST > select USB_CHIPIDEA_TEGRA > + select USB_GADGET > help > This option is deprecated now and the driver was removed, use > USB_CHIPIDEA_TEGRA instead. > -- > 2.30.2 >
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index b94f2a070c05..df9428f1dc5e 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -272,6 +272,7 @@ config USB_EHCI_TEGRA select USB_CHIPIDEA select USB_CHIPIDEA_HOST select USB_CHIPIDEA_TEGRA + select USB_GADGET help This option is deprecated now and the driver was removed, use USB_CHIPIDEA_TEGRA instead.
Select USB_GADGET Kconfig option in order to fix build failure which happens because ChipIdea driver has a build dependency on both USB_GADGET and USB_EHCI_HCD, while USB_EHCI_TEGRA force-selects the ChipIdea driver without taking into account the tristate USB_GADGET dependency. It's not possible to do anything about the cyclic dependency of the Kconfig options, but USB_EHCI_TEGRA is now a deprecated option that isn't used by defconfigs and USB_GADGET is wanted on Tegra by default, hence it's okay to have a bit clunky workaround for it. Fixes: c3590c7656fb ("usb: host: ehci-tegra: Remove the driver") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/usb/host/Kconfig | 1 + 1 file changed, 1 insertion(+)