From patchwork Wed Dec 2 08:15:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Eichenberger X-Patchwork-Id: 1409420 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Vn8Ro5FO; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CmBdf4pdSz9ryj for ; Wed, 2 Dec 2020 19:16:54 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728962AbgLBIQi (ORCPT ); Wed, 2 Dec 2020 03:16:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728960AbgLBIQh (ORCPT ); Wed, 2 Dec 2020 03:16:37 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45DEFC0613CF for ; Wed, 2 Dec 2020 00:15:57 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id e25so5086677wme.0 for ; Wed, 02 Dec 2020 00:15:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hxJnMGt2KDgNIihAgZquJcCD+5vdun+/UIpInThRpcw=; b=Vn8Ro5FOY8w2LaBjs4BdoaWTxJTCQAnHB6UPwBPZrUwRZLppMLtfv17nqYkYdASnuT sBKgfaK8pL4p0QVVkHNPe0/5d/GhaihSuJQtgMR7qoLCpKheLVq2cwg+b9YToV/P1eVJ rUuIWDBQZwoaGPJVE4wmcHheCtAtRdAoFja2HKvb0buMuMZkAexcZ26q3fB3Sym/MZk6 n/dfT+0VG3wDAQcZ5wLFm0j/X1KsTfVwRk+29Sk+a49crBKTxXaQ4a3e4YGslDhZJZzu 3m/qwNPIK1JW4IxYwu37LryKO6UcnSKoLXVFQAu5GVjJzBCITxS9iAtjBBN7rS6cUuqF dAjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hxJnMGt2KDgNIihAgZquJcCD+5vdun+/UIpInThRpcw=; b=JVFXaMmOm0G+yr9Rj983Hy1hRMQy4KeRSRHxuyNCRj58RgoA8ahvM3irzQaBjG6JJj DaUpWa783j54eLzhmw0oxuptnM+wGPL4LgleAMK1dlhoa/tvsumxnnZGkTuEl2K0dZQn 74AQ1e6S4ZcqIJJISgICY02YstTGoQ1yEApzi1aAB2fP/1F1LJJea0i0eEiHSfdhhkAD dZ6ysungfisP1WU6QgcA+8BWMWWOmwQ8BRwTv1lfZMh8OwTAM7KxIOmTwCioxC4Zhl4y BBPZoLbsFhGmTaQtXsFbQdK7dwVEZwqjfUVC9U+oeVbw6JaYwCIT3JR6RHYdMPXpfzCu RkTQ== X-Gm-Message-State: AOAM531nm9E0f/3EO6YsFDgEpnw3fvkO6LBDAaWdp9cpeLJA33G8dUdv fpT818cTrBms9WWaOjF7IApKM4cMLJRrzA== X-Google-Smtp-Source: ABdhPJw68GVoM4YaRNPSbiTqsk5jLOJHJe91pKfZPQJmqXWyCFz1tLx8X90hJxHjib7bHXKAM25cTA== X-Received: by 2002:a1c:2e16:: with SMTP id u22mr1774676wmu.149.1606896955490; Wed, 02 Dec 2020 00:15:55 -0800 (PST) Received: from stefan-nb.local (77-57-203-148.dclient.hispeed.ch. [77.57.203.148]) by smtp.gmail.com with ESMTPSA id o67sm1029010wmo.31.2020.12.02.00.15.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 00:15:54 -0800 (PST) From: eichest@gmail.com X-Google-Original-From: stefan.eichenberger@toradex.com To: linux-tegra@vger.kernel.org Cc: jonathanh@nvidia.com, thierry.reding@gmail.com, Stefan Eichenberger Subject: [PATCH] ARM: tegra: add usb-role-switch property to usb otg ports Date: Wed, 2 Dec 2020 09:15:38 +0100 Message-Id: <20201202081538.86822-1-stefan.eichenberger@toradex.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org From: Stefan Eichenberger If an usb port is an otg port we should add the usb-role-switch property. If it is not set xusb will fail and therefore padctl will never be able to setup the ports. This will lead to broken usb and broken pcie. The error message shown without this patch is e.g: usb2-0: usb-role-switch not found for otg mode Signed-off-by: Stefan Eichenberger --- arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 1 + arch/arm/boot/dts/tegra124-apalis.dtsi | 1 + arch/arm/boot/dts/tegra124-nyan.dtsi | 1 + arch/arm/boot/dts/tegra124-venice2.dts | 2 +- 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi b/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi index 1e30fa405fa0..3c31bcc79c48 100644 --- a/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi +++ b/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi @@ -1885,6 +1885,7 @@ ports { usb2-0 { status = "okay"; mode = "otg"; + usb-role-switch; vbus-supply = <®_usbo1_vbus>; }; diff --git a/arch/arm/boot/dts/tegra124-apalis.dtsi b/arch/arm/boot/dts/tegra124-apalis.dtsi index 608896f8dd52..4a23b26b0eef 100644 --- a/arch/arm/boot/dts/tegra124-apalis.dtsi +++ b/arch/arm/boot/dts/tegra124-apalis.dtsi @@ -1877,6 +1877,7 @@ ports { usb2-0 { status = "okay"; mode = "otg"; + usb-role-switch; vbus-supply = <®_usbo1_vbus>; }; diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi index 5f71add38dfe..5ba5c6ef6285 100644 --- a/arch/arm/boot/dts/tegra124-nyan.dtsi +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi @@ -466,6 +466,7 @@ usb2-0 { vbus-supply = <&vdd_usb1_vbus>; status = "okay"; mode = "otg"; + usb-role-switch; }; usb2-1 { diff --git a/arch/arm/boot/dts/tegra124-venice2.dts b/arch/arm/boot/dts/tegra124-venice2.dts index e6b54ac1ebd1..de8c18e6b7e6 100644 --- a/arch/arm/boot/dts/tegra124-venice2.dts +++ b/arch/arm/boot/dts/tegra124-venice2.dts @@ -972,7 +972,7 @@ ports { usb2-0 { status = "okay"; mode = "otg"; - + usb-role-switch; vbus-supply = <&vdd_usb1_vbus>; };