| Message ID | 20201114051219.GA4746@fedora-project |
|---|---|
| State | Deferred |
| Headers | show |
| Series | memory: tegra20-emc: remove redundant error message | expand |
14.11.2020 08:12, Nigel Christian пишет: > There is no need for dev_err() since irq already prints an error. > Eliminate unnecessary curly braces for single statement block. > > Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com> > --- > drivers/memory/tegra/tegra20-emc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c > index 5e10aa97809f..181a360d7d6b 100644 > --- a/drivers/memory/tegra/tegra20-emc.c > +++ b/drivers/memory/tegra/tegra20-emc.c > @@ -959,10 +959,8 @@ static int tegra_emc_probe(struct platform_device *pdev) > int irq, err; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(&pdev->dev, "please update your device tree\n"); > + if (irq < 0) > return irq; > - } > > emc = devm_kzalloc(&pdev->dev, sizeof(*emc), GFP_KERNEL); > if (!emc) > This message has a special purpose, it shouldn't be removed. Please always check what auto-generated patches actually do.
On Sat, Nov 14, 2020 at 08:33:47AM +0300, Dmitry Osipenko wrote: > 14.11.2020 08:12, Nigel Christian пишет: > > There is no need for dev_err() since irq already prints an error. > > Eliminate unnecessary curly braces for single statement block. > > > > Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com> > > --- > > drivers/memory/tegra/tegra20-emc.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c > > index 5e10aa97809f..181a360d7d6b 100644 > > --- a/drivers/memory/tegra/tegra20-emc.c > > +++ b/drivers/memory/tegra/tegra20-emc.c > > @@ -959,10 +959,8 @@ static int tegra_emc_probe(struct platform_device *pdev) > > int irq, err; > > > > irq = platform_get_irq(pdev, 0); > > - if (irq < 0) { > > - dev_err(&pdev->dev, "please update your device tree\n"); > > + if (irq < 0) > > return irq; > > - } > > > > emc = devm_kzalloc(&pdev->dev, sizeof(*emc), GFP_KERNEL); > > if (!emc) > > > > This message has a special purpose, it shouldn't be removed. Please > always check what auto-generated patches actually do. Apologies, understood. Thank you for your time.
diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c index 5e10aa97809f..181a360d7d6b 100644 --- a/drivers/memory/tegra/tegra20-emc.c +++ b/drivers/memory/tegra/tegra20-emc.c @@ -959,10 +959,8 @@ static int tegra_emc_probe(struct platform_device *pdev) int irq, err; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "please update your device tree\n"); + if (irq < 0) return irq; - } emc = devm_kzalloc(&pdev->dev, sizeof(*emc), GFP_KERNEL); if (!emc)
There is no need for dev_err() since irq already prints an error. Eliminate unnecessary curly braces for single statement block. Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com> --- drivers/memory/tegra/tegra20-emc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)