| Message ID | 20201103114426.546626-1-jonathanh@nvidia.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | drm/tegra: sor: Don't warn on probe deferral | expand |
On 03/11/2020 11:44, Jon Hunter wrote: > Deferred probe is an expected return value for tegra_output_probe(). > Given that the driver deals with it properly, there's no need to output > a warning that may potentially confuse users. > > Signed-off-by: Jon Hunter <jonathanh@nvidia.com> > --- > drivers/gpu/drm/tegra/sor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c > index e88a17c2937f..5a232055b8cc 100644 > --- a/drivers/gpu/drm/tegra/sor.c > +++ b/drivers/gpu/drm/tegra/sor.c > @@ -3765,7 +3765,7 @@ static int tegra_sor_probe(struct platform_device *pdev) > > err = tegra_output_probe(&sor->output); > if (err < 0) { > - dev_err(&pdev->dev, "failed to probe output: %d\n", err); > + dev_err_probe(&pdev->dev, "failed to probe output: %d\n", err); > return err; > } Sorry this is not right. I will fix this in V2. Jon
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index e88a17c2937f..5a232055b8cc 100644 --- a/drivers/gpu/drm/tegra/sor.c +++ b/drivers/gpu/drm/tegra/sor.c @@ -3765,7 +3765,7 @@ static int tegra_sor_probe(struct platform_device *pdev) err = tegra_output_probe(&sor->output); if (err < 0) { - dev_err(&pdev->dev, "failed to probe output: %d\n", err); + dev_err_probe(&pdev->dev, "failed to probe output: %d\n", err); return err; }
Deferred probe is an expected return value for tegra_output_probe(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users. Signed-off-by: Jon Hunter <jonathanh@nvidia.com> --- drivers/gpu/drm/tegra/sor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)