| Message ID | 20201025221735.3062-51-digetx@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v6,01/52] clk: tegra: Export Tegra20 EMC kernel symbols | expand |
On 10/26/20 7:17 AM, Dmitry Osipenko wrote: > Tegra EMC driver was turned into a regular kernel driver, meaning that it > could be compiled as a loadable kernel module now. Hence EMC clock isn't > guaranteed to be available and clk_get("emc") may return -EPROBE_DEFER. > Let's silence the deferred probe error. > > Acked-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/devfreq/tegra30-devfreq.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > index f5e74c2ede85..3f732ab53573 100644 > --- a/drivers/devfreq/tegra30-devfreq.c > +++ b/drivers/devfreq/tegra30-devfreq.c > @@ -801,10 +801,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) > } > > tegra->emc_clock = devm_clk_get(&pdev->dev, "emc"); > - if (IS_ERR(tegra->emc_clock)) { > - dev_err(&pdev->dev, "Failed to get emc clock\n"); > - return PTR_ERR(tegra->emc_clock); > - } > + if (IS_ERR(tegra->emc_clock)) > + return dev_err_probe(&pdev->dev, PTR_ERR(tegra->emc_clock), > + "Failed to get emc clock\n"); > > err = platform_get_irq(pdev, 0); > if (err < 0) > Applied it. Thanks.
diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c index f5e74c2ede85..3f732ab53573 100644 --- a/drivers/devfreq/tegra30-devfreq.c +++ b/drivers/devfreq/tegra30-devfreq.c @@ -801,10 +801,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) } tegra->emc_clock = devm_clk_get(&pdev->dev, "emc"); - if (IS_ERR(tegra->emc_clock)) { - dev_err(&pdev->dev, "Failed to get emc clock\n"); - return PTR_ERR(tegra->emc_clock); - } + if (IS_ERR(tegra->emc_clock)) + return dev_err_probe(&pdev->dev, PTR_ERR(tegra->emc_clock), + "Failed to get emc clock\n"); err = platform_get_irq(pdev, 0); if (err < 0)
Tegra EMC driver was turned into a regular kernel driver, meaning that it could be compiled as a loadable kernel module now. Hence EMC clock isn't guaranteed to be available and clk_get("emc") may return -EPROBE_DEFER. Let's silence the deferred probe error. Acked-by: Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/devfreq/tegra30-devfreq.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)