| Message ID | 20201025221735.3062-32-digetx@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v6,01/52] clk: tegra: Export Tegra20 EMC kernel symbols | expand |
On Mon, Oct 26, 2020 at 01:17:14AM +0300, Dmitry Osipenko wrote: > Use devm_platform_ioremap_resource() helper which makes code a bit > cleaner. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/memory/tegra/tegra20-emc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) I'm not a fan of this helper, to be honest, because I think all the churn that we've seen with the conversions isn't really worth the 1 or 2 lines that it saves, but hey, looks like this is pretty broadly accepted, so if Krzysztof likes it: Acked-by: Thierry Reding <treding@nvidia.com>
On Tue, 27 Oct 2020 at 14:50, Thierry Reding <thierry.reding@gmail.com> wrote: > > On Mon, Oct 26, 2020 at 01:17:14AM +0300, Dmitry Osipenko wrote: > > Use devm_platform_ioremap_resource() helper which makes code a bit > > cleaner. > > > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > > --- > > drivers/memory/tegra/tegra20-emc.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > I'm not a fan of this helper, to be honest, because I think all the > churn that we've seen with the conversions isn't really worth the 1 or 2 > lines that it saves, but hey, looks like this is pretty broadly > accepted, so if Krzysztof likes it: > > Acked-by: Thierry Reding <treding@nvidia.com> Such changes indeed do not bring much but still less local variables and -1 line. I am fine with them. They also save one error msg from devm_ioremap_resource() in case of platform_get_resource() failure. Best regards, Krzysztof
diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c index 0baa6590adea..ce22ca7cfb77 100644 --- a/drivers/memory/tegra/tegra20-emc.c +++ b/drivers/memory/tegra/tegra20-emc.c @@ -654,7 +654,6 @@ static int tegra_emc_probe(struct platform_device *pdev) { struct device_node *np; struct tegra_emc *emc; - struct resource *res; int irq, err; /* driver has nothing to do in a case of memory timing absence */ @@ -689,8 +688,7 @@ static int tegra_emc_probe(struct platform_device *pdev) if (err) return err; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - emc->regs = devm_ioremap_resource(&pdev->dev, res); + emc->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(emc->regs)) return PTR_ERR(emc->regs);
Use devm_platform_ioremap_resource() helper which makes code a bit cleaner. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/memory/tegra/tegra20-emc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)