| Message ID | 20201008003746.25659-6-nicoleotsuka@gmail.com |
|---|---|
| State | Deferred |
| Headers | show |
| Series | memory: tegra: Fix client list and add swgroups | expand |
On Wed, Oct 07, 2020 at 05:37:46PM -0700, Nicolin Chen wrote: > According to Tegra X1 TRM, there are missing swgroups in the > tegra210_swgroups list. So this patch adds them to the list. > > Note that the TEGRA_SWGROUP_GPU (in list) should be actually > TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGROUP_GPU (in TRM) > is not being used -- only TEGRA_SWGROUP_GPUB (in TRM) is. So > this patch does not add TEGRA_SWGROUP_GPU (in TRM) and keeps > TEGRA_SWGROUP_GPU (in list) as it is. > > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> > --- > drivers/memory/tegra/tegra210.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/memory/tegra/tegra210.c b/drivers/memory/tegra/tegra210.c > index b400802c9f14..b3bbc5a05ba1 100644 > --- a/drivers/memory/tegra/tegra210.c > +++ b/drivers/memory/tegra/tegra210.c > @@ -1028,6 +1028,8 @@ static const struct tegra_smmu_swgroup tegra210_swgroups[] = { > { .name = "hda", .swgroup = TEGRA_SWGROUP_HDA, .reg = 0x254 }, > { .name = "isp2", .swgroup = TEGRA_SWGROUP_ISP2, .reg = 0x258 }, > { .name = "nvenc", .swgroup = TEGRA_SWGROUP_NVENC, .reg = 0x264 }, > + { .name = "nv", .swgroup = TEGRA_SWGROUP_NV, .reg = 0x268 }, > + { .name = "nv2", .swgroup = TEGRA_SWGROUP_NV2, .reg = 0x26c }, Oddly enough I can see these in the TRM, but they are not in the internal reference manuals that are supposed to be the canonical reference for the TRM. Perhaps the TRM is out of date? Thierry
On Tue, Oct 27, 2020 at 02:01:11PM +0100, Thierry Reding wrote: > On Wed, Oct 07, 2020 at 05:37:46PM -0700, Nicolin Chen wrote: > > According to Tegra X1 TRM, there are missing swgroups in the > > tegra210_swgroups list. So this patch adds them to the list. > > > > Note that the TEGRA_SWGROUP_GPU (in list) should be actually > > TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGROUP_GPU (in TRM) > > is not being used -- only TEGRA_SWGROUP_GPUB (in TRM) is. So > > this patch does not add TEGRA_SWGROUP_GPU (in TRM) and keeps > > TEGRA_SWGROUP_GPU (in list) as it is. > > > > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> > > --- > > drivers/memory/tegra/tegra210.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/memory/tegra/tegra210.c b/drivers/memory/tegra/tegra210.c > > index b400802c9f14..b3bbc5a05ba1 100644 > > --- a/drivers/memory/tegra/tegra210.c > > +++ b/drivers/memory/tegra/tegra210.c > > @@ -1028,6 +1028,8 @@ static const struct tegra_smmu_swgroup tegra210_swgroups[] = { > > { .name = "hda", .swgroup = TEGRA_SWGROUP_HDA, .reg = 0x254 }, > > { .name = "isp2", .swgroup = TEGRA_SWGROUP_ISP2, .reg = 0x258 }, > > { .name = "nvenc", .swgroup = TEGRA_SWGROUP_NVENC, .reg = 0x264 }, > > + { .name = "nv", .swgroup = TEGRA_SWGROUP_NV, .reg = 0x268 }, > > + { .name = "nv2", .swgroup = TEGRA_SWGROUP_NV2, .reg = 0x26c }, > > Oddly enough I can see these in the TRM, but they are not in the > internal reference manuals that are supposed to be the canonical > reference for the TRM. Perhaps the TRM is out of date? Hmm..I actually have been using the TRM from official site all the time. These two aren't being used downstream either; I put them in the patch merely because they exist in the TRM. So we may drop them if you feel that's better.
On Wed, Oct 07, 2020 at 05:37:46PM -0700, Nicolin Chen wrote: > According to Tegra X1 TRM, there are missing swgroups in the > tegra210_swgroups list. So this patch adds them to the list. > > Note that the TEGRA_SWGROUP_GPU (in list) should be actually > TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGROUP_GPU (in TRM) > is not being used -- only TEGRA_SWGROUP_GPUB (in TRM) is. So > this patch does not add TEGRA_SWGROUP_GPU (in TRM) and keeps > TEGRA_SWGROUP_GPU (in list) as it is. > > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> > --- > drivers/memory/tegra/tegra210.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) Acked-by: Thierry Reding <treding@nvidia.com>
On Wed, Oct 07, 2020 at 05:37:46PM -0700, Nicolin Chen wrote: > According to Tegra X1 TRM, there are missing swgroups in the > tegra210_swgroups list. So this patch adds them to the list. > > Note that the TEGRA_SWGROUP_GPU (in list) should be actually > TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGROUP_GPU (in TRM) > is not being used -- only TEGRA_SWGROUP_GPUB (in TRM) is. So > this patch does not add TEGRA_SWGROUP_GPU (in TRM) and keeps > TEGRA_SWGROUP_GPU (in list) as it is. > > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> > --- > drivers/memory/tegra/tegra210.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) Thanks, applied. Best regards, Krzysztof
diff --git a/drivers/memory/tegra/tegra210.c b/drivers/memory/tegra/tegra210.c index b400802c9f14..b3bbc5a05ba1 100644 --- a/drivers/memory/tegra/tegra210.c +++ b/drivers/memory/tegra/tegra210.c @@ -1028,6 +1028,8 @@ static const struct tegra_smmu_swgroup tegra210_swgroups[] = { { .name = "hda", .swgroup = TEGRA_SWGROUP_HDA, .reg = 0x254 }, { .name = "isp2", .swgroup = TEGRA_SWGROUP_ISP2, .reg = 0x258 }, { .name = "nvenc", .swgroup = TEGRA_SWGROUP_NVENC, .reg = 0x264 }, + { .name = "nv", .swgroup = TEGRA_SWGROUP_NV, .reg = 0x268 }, + { .name = "nv2", .swgroup = TEGRA_SWGROUP_NV2, .reg = 0x26c }, { .name = "ppcs", .swgroup = TEGRA_SWGROUP_PPCS, .reg = 0x270 }, { .name = "sata", .swgroup = TEGRA_SWGROUP_SATA, .reg = 0x274 }, { .name = "vi", .swgroup = TEGRA_SWGROUP_VI, .reg = 0x280 }, @@ -1036,19 +1038,27 @@ static const struct tegra_smmu_swgroup tegra210_swgroups[] = { { .name = "xusb_dev", .swgroup = TEGRA_SWGROUP_XUSB_DEV, .reg = 0x28c }, { .name = "a9avp", .swgroup = TEGRA_SWGROUP_A9AVP, .reg = 0x290 }, { .name = "tsec", .swgroup = TEGRA_SWGROUP_TSEC, .reg = 0x294 }, + { .name = "ppcs1", .swgroup = TEGRA_SWGROUP_PPCS1, .reg = 0x298 }, + { .name = "dc1", .swgroup = TEGRA_SWGROUP_DC1, .reg = 0xa88 }, { .name = "sdmmc1a", .swgroup = TEGRA_SWGROUP_SDMMC1A, .reg = 0xa94 }, { .name = "sdmmc2a", .swgroup = TEGRA_SWGROUP_SDMMC2A, .reg = 0xa98 }, { .name = "sdmmc3a", .swgroup = TEGRA_SWGROUP_SDMMC3A, .reg = 0xa9c }, { .name = "sdmmc4a", .swgroup = TEGRA_SWGROUP_SDMMC4A, .reg = 0xaa0 }, { .name = "isp2b", .swgroup = TEGRA_SWGROUP_ISP2B, .reg = 0xaa4 }, { .name = "gpu", .swgroup = TEGRA_SWGROUP_GPU, .reg = 0xaac }, + { .name = "ppcs2", .swgroup = TEGRA_SWGROUP_PPCS2, .reg = 0xab0 }, { .name = "nvdec", .swgroup = TEGRA_SWGROUP_NVDEC, .reg = 0xab4 }, { .name = "ape", .swgroup = TEGRA_SWGROUP_APE, .reg = 0xab8 }, { .name = "se", .swgroup = TEGRA_SWGROUP_SE, .reg = 0xabc }, { .name = "nvjpg", .swgroup = TEGRA_SWGROUP_NVJPG, .reg = 0xac0 }, + { .name = "hc1", .swgroup = TEGRA_SWGROUP_HC1, .reg = 0xac4 }, + { .name = "se1", .swgroup = TEGRA_SWGROUP_SE1, .reg = 0xac8 }, { .name = "axiap", .swgroup = TEGRA_SWGROUP_AXIAP, .reg = 0xacc }, { .name = "etr", .swgroup = TEGRA_SWGROUP_ETR, .reg = 0xad0 }, { .name = "tsecb", .swgroup = TEGRA_SWGROUP_TSECB, .reg = 0xad4 }, + { .name = "tsec1", .swgroup = TEGRA_SWGROUP_TSEC1, .reg = 0xad8 }, + { .name = "tsecb1", .swgroup = TEGRA_SWGROUP_TSECB1, .reg = 0xadc }, + { .name = "nvdec1", .swgroup = TEGRA_SWGROUP_NVDEC1, .reg = 0xae0 }, }; static const unsigned int tegra210_group_display[] = {
According to Tegra X1 TRM, there are missing swgroups in the tegra210_swgroups list. So this patch adds them to the list. Note that the TEGRA_SWGROUP_GPU (in list) should be actually TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGROUP_GPU (in TRM) is not being used -- only TEGRA_SWGROUP_GPUB (in TRM) is. So this patch does not add TEGRA_SWGROUP_GPU (in TRM) and keeps TEGRA_SWGROUP_GPU (in list) as it is. Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> --- drivers/memory/tegra/tegra210.c | 10 ++++++++++ 1 file changed, 10 insertions(+)