diff mbox series

[v2] Staging: nvec: nvec: fix double next comment

Message ID 20200927163504.7546-1-ryanpkosta@gmail.com
State New
Headers show
Series [v2] Staging: nvec: nvec: fix double next comment | expand

Commit Message

Ryan Kosta Sept. 27, 2020, 4:35 p.m. UTC
Changes since v1:
 * Made commit message more clear
 * Added description
Note: previous patch named
 "[PATCH] fix double next comment in drivers/staging/nvec/nvec.c"
>8------------------------------------------------------8<
Fixes a comment typo.

Signed-off-by: Ryan Kosta <ryanpkosta@gmail.com>
---
 drivers/staging/nvec/nvec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Joe Perches Sept. 27, 2020, 4:45 p.m. UTC | #1
On Sun, 2020-09-27 at 09:35 -0700, Ryan Kosta wrote:
> Changes since v1:
>  * Made commit message more clear
>  * Added description
> Note: previous patch named
>  "[PATCH] fix double next comment in drivers/staging/nvec/nvec.c"
> > 8------------------------------------------------------8<
> Fixes a comment typo.

Hi Ryan.

That comment should be _below_ the --- separator line

There's no need to double the nvec: word in the subject either.
And please use the imperative.

So the email message should look something like:

---------------------------------------------------------

From: <you>

Subject: [PATCH V2] staging: nvec: Remove repeated word typo in a comment

Fix a comment typo.

Signed-off-by: <you>
---

V2: Add a commit description

<patch>
diff mbox series

Patch

diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 360ec040774..a80996b2f5c 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -289,7 +289,7 @@  EXPORT_SYMBOL(nvec_write_async);
  * interrupt handlers.
  *
  * Returns: 0 on success, a negative error code on failure.
- * The response message is returned in @msg. Shall be freed with
+ * The response message is returned in @msg. Shall be freed
  * with nvec_msg_free() once no longer used.
  *
  */