diff mbox series

[v2,1/3] dt-bindings: input: atmel: add compatible for mXT1386

Message ID 20200925135257.21138-2-jiada_wang@mentor.com
State New
Headers show
Series implement I2C retries for mXT1368 | expand

Commit Message

Wang, Jiada Sept. 25, 2020, 1:52 p.m. UTC
Document the mXT1386 compatible string.

Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
---
 Documentation/devicetree/bindings/input/atmel,maxtouch.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Dmitry Osipenko Sept. 25, 2020, 9:01 p.m. UTC | #1
25.09.2020 16:52, Jiada Wang пишет:
> Document the mXT1386 compatible string.
> 
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> ---
>  Documentation/devicetree/bindings/input/atmel,maxtouch.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.txt b/Documentation/devicetree/bindings/input/atmel,maxtouch.txt
> index c88919480d37..c13fc0f3f00b 100644
> --- a/Documentation/devicetree/bindings/input/atmel,maxtouch.txt
> +++ b/Documentation/devicetree/bindings/input/atmel,maxtouch.txt
> @@ -3,6 +3,7 @@ Atmel maXTouch touchscreen/touchpad
>  Required properties:
>  - compatible:
>      atmel,maxtouch
> +    atmel,mXT1386
>  
>      The following compatibles have been used in various products but are
>      deprecated:
> 

Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Thierry Reding Sept. 28, 2020, 6:59 a.m. UTC | #2
On Fri, Sep 25, 2020 at 10:52:55PM +0900, Jiada Wang wrote:
> Document the mXT1386 compatible string.
> 
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> ---
>  Documentation/devicetree/bindings/input/atmel,maxtouch.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.txt b/Documentation/devicetree/bindings/input/atmel,maxtouch.txt
> index c88919480d37..c13fc0f3f00b 100644
> --- a/Documentation/devicetree/bindings/input/atmel,maxtouch.txt
> +++ b/Documentation/devicetree/bindings/input/atmel,maxtouch.txt
> @@ -3,6 +3,7 @@ Atmel maXTouch touchscreen/touchpad
>  Required properties:
>  - compatible:
>      atmel,maxtouch
> +    atmel,mXT1386

Compatible strings are preferred to be all lowercase.

Thierry
Wang, Jiada Sept. 30, 2020, 2:22 p.m. UTC | #3
Hi Thierry

Thanks for your comment

On 2020/09/28 15:59, Thierry Reding wrote:
> On Fri, Sep 25, 2020 at 10:52:55PM +0900, Jiada Wang wrote:
>> Document the mXT1386 compatible string.
>>
>> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
>> ---
>>   Documentation/devicetree/bindings/input/atmel,maxtouch.txt | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.txt b/Documentation/devicetree/bindings/input/atmel,maxtouch.txt
>> index c88919480d37..c13fc0f3f00b 100644
>> --- a/Documentation/devicetree/bindings/input/atmel,maxtouch.txt
>> +++ b/Documentation/devicetree/bindings/input/atmel,maxtouch.txt
>> @@ -3,6 +3,7 @@ Atmel maXTouch touchscreen/touchpad
>>   Required properties:
>>   - compatible:
>>       atmel,maxtouch
>> +    atmel,mXT1386
> 
> Compatible strings are preferred to be all lowercase.

I will update to use lowercase

Thanks,
Jiada
> 
> Thierry
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.txt b/Documentation/devicetree/bindings/input/atmel,maxtouch.txt
index c88919480d37..c13fc0f3f00b 100644
--- a/Documentation/devicetree/bindings/input/atmel,maxtouch.txt
+++ b/Documentation/devicetree/bindings/input/atmel,maxtouch.txt
@@ -3,6 +3,7 @@  Atmel maXTouch touchscreen/touchpad
 Required properties:
 - compatible:
     atmel,maxtouch
+    atmel,mXT1386
 
     The following compatibles have been used in various products but are
     deprecated: