| Message ID | 20200724074038.5597-6-krzk@kernel.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | *memory: Cleanup, improve and compile test memory drivers | expand |
On Fri, Jul 24, 2020 at 9:41 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > When compile testing, enable the driver by default only on MIPS > architecture. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > Changes since v1: > 1. New patch @@ -141,7 +141,7 @@ config FSL_IFC > > config JZ4780_NEMC > bool "Ingenic JZ4780 SoC NEMC driver" > - default y > + default y if MIPS > depends on MIPS || COMPILE_TEST Actually I think this should be 'default MACH_INGENIC', and probably also 'depends on MACH_INGENIC || COMPILE_TEST'. Arnd
On Fri, Jul 24, 2020 at 03:45:37PM +0200, Arnd Bergmann wrote: > On Fri, Jul 24, 2020 at 9:41 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > When compile testing, enable the driver by default only on MIPS > > architecture. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > > > --- > > > > Changes since v1: > > 1. New patch > @@ -141,7 +141,7 @@ config FSL_IFC > > > > config JZ4780_NEMC > > bool "Ingenic JZ4780 SoC NEMC driver" > > - default y > > + default y if MIPS > > depends on MIPS || COMPILE_TEST > > > Actually I think this should be 'default MACH_INGENIC', > and probably also 'depends on MACH_INGENIC || COMPILE_TEST'. Makes sense, especially for default. For the depends, there is also MTD_NAND_JZ4780 (depending on JZ4780_NEMC) which also requires MIPS. I could fix both then. Best regards, Krzysztof
diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig index efcb4dfaccc2..5a225ca66c4e 100644 --- a/drivers/memory/Kconfig +++ b/drivers/memory/Kconfig @@ -141,7 +141,7 @@ config FSL_IFC config JZ4780_NEMC bool "Ingenic JZ4780 SoC NEMC driver" - default y + default y if MIPS depends on MIPS || COMPILE_TEST depends on HAS_IOMEM && OF help
When compile testing, enable the driver by default only on MIPS architecture. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Changes since v1: 1. New patch --- drivers/memory/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)