| Message ID | 20200708202355.28507-3-digetx@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Improvements for MAX77620 GPIO driver | expand |
On Thursday 09 July 2020 01:53 AM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > The requested interrupt is never released by the driver. Fix this by > using the resource-managed variant of request_threaded_irq(). > > Fixes: ab3dd9cc24d4 ("gpio: max77620: Fix interrupt handling") > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> Looks good to me. Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
09.07.2020 17:57, Laxman Dewangan пишет: > > > On Thursday 09 July 2020 01:53 AM, Dmitry Osipenko wrote: >> External email: Use caution opening links or attachments >> >> >> The requested interrupt is never released by the driver. Fix this by >> using the resource-managed variant of request_threaded_irq(). >> >> Fixes: ab3dd9cc24d4 ("gpio: max77620: Fix interrupt handling") >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > > > Looks good to me. > Acked-by: Laxman Dewangan <ldewangan@nvidia.com> Hello, Laxman! Thank you very much for taking a look at this series! I missed to add the stable tag to this patch, so will prepare a v4 with the corrected tag. I'll also add yours acks and Andy's r-bs to the patches. Thanks!
diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c index 4c0c9ec2587d..7f7e8d4bf0d3 100644 --- a/drivers/gpio/gpio-max77620.c +++ b/drivers/gpio/gpio-max77620.c @@ -305,8 +305,9 @@ static int max77620_gpio_probe(struct platform_device *pdev) gpiochip_irqchip_add_nested(&mgpio->gpio_chip, &max77620_gpio_irqchip, 0, handle_edge_irq, IRQ_TYPE_NONE); - ret = request_threaded_irq(gpio_irq, NULL, max77620_gpio_irqhandler, - IRQF_ONESHOT, "max77620-gpio", mgpio); + ret = devm_request_threaded_irq(&pdev->dev, gpio_irq, NULL, + max77620_gpio_irqhandler, IRQF_ONESHOT, + "max77620-gpio", mgpio); if (ret < 0) { dev_err(&pdev->dev, "failed to request IRQ: %d\n", ret); return ret;
The requested interrupt is never released by the driver. Fix this by using the resource-managed variant of request_threaded_irq(). Fixes: ab3dd9cc24d4 ("gpio: max77620: Fix interrupt handling") Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/gpio/gpio-max77620.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)