| Message ID | 20200708155834.19762-3-digetx@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Improvements for MAX77620 GPIO driver | expand |
On Wed, Jul 8, 2020 at 6:58 PM Dmitry Osipenko <digetx@gmail.com> wrote: > > The MAX77620_GPIO_NR enum value represents the total number of GPIOs, > let's use it instead of a raw value in order to improve the code's > readability a tad. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/gpio/gpio-max77620.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c > index 970ad6397a56..08bd5b141437 100644 > --- a/drivers/gpio/gpio-max77620.c > +++ b/drivers/gpio/gpio-max77620.c > @@ -19,8 +19,8 @@ struct max77620_gpio { > struct regmap *rmap; > struct device *dev; > struct mutex buslock; /* irq_bus_lock */ > - unsigned int irq_type[8]; > - bool irq_enabled[8]; > + unsigned int irq_type[MAX77620_GPIO_NR]; > + bool irq_enabled[MAX77620_GPIO_NR]; > }; > > static irqreturn_t max77620_gpio_irqhandler(int irq, void *data) > @@ -38,7 +38,7 @@ static irqreturn_t max77620_gpio_irqhandler(int irq, void *data) > > pending = value; > > - for_each_set_bit(offset, &pending, 8) { > + for_each_set_bit(offset, &pending, MAX77620_GPIO_NR) { > unsigned int virq; > > virq = irq_find_mapping(gpio->gpio_chip.irq.domain, offset); > -- > 2.26.0 >
diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c index 970ad6397a56..08bd5b141437 100644 --- a/drivers/gpio/gpio-max77620.c +++ b/drivers/gpio/gpio-max77620.c @@ -19,8 +19,8 @@ struct max77620_gpio { struct regmap *rmap; struct device *dev; struct mutex buslock; /* irq_bus_lock */ - unsigned int irq_type[8]; - bool irq_enabled[8]; + unsigned int irq_type[MAX77620_GPIO_NR]; + bool irq_enabled[MAX77620_GPIO_NR]; }; static irqreturn_t max77620_gpio_irqhandler(int irq, void *data) @@ -38,7 +38,7 @@ static irqreturn_t max77620_gpio_irqhandler(int irq, void *data) pending = value; - for_each_set_bit(offset, &pending, 8) { + for_each_set_bit(offset, &pending, MAX77620_GPIO_NR) { unsigned int virq; virq = irq_find_mapping(gpio->gpio_chip.irq.domain, offset);
The MAX77620_GPIO_NR enum value represents the total number of GPIOs, let's use it instead of a raw value in order to improve the code's readability a tad. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/gpio/gpio-max77620.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)