| Message ID | 20200603111923.3545261-2-thierry.reding@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] clk: tegra: Capitalization fixes | expand |
On Wed, Jun 03, 2020 at 01:19:23PM +0200, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Commit bff1cef5f23a ("clk: tegra: Don't enable already enabled PLLs") > added checks to avoid enabling PLLs that have already been enabled by > the bootloader. However, the PLL_E configuration inherited from the > bootloader isn't necessarily the one that is needed for the kernel. > > This can cause SATA to fail like this: > > [ 5.310270] phy phy-sata.6: phy poweron failed --> -110 > [ 5.315604] tegra-ahci 70027000.sata: failed to power on AHCI controller: -110 > [ 5.323022] tegra-ahci: probe of 70027000.sata failed with error -110 > > Fix this by always programming the PLL_E. This ensures that any mis- > configuration by the bootloader will be overwritten by the kernel. > > Fixes: bff1cef5f23a ("clk: tegra: Don't enable already enabled PLLs") > Reported-by: LABBE Corentin <clabbe@baylibre.com> > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/clk/tegra/clk-pll.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c > index 583d2ac61e9e..b2d39a66f0fa 100644 > --- a/drivers/clk/tegra/clk-pll.c > +++ b/drivers/clk/tegra/clk-pll.c > @@ -1601,9 +1601,6 @@ static int clk_plle_tegra114_enable(struct clk_hw *hw) > unsigned long flags = 0; > unsigned long input_rate; > > - if (clk_pll_is_enabled(hw)) > - return 0; > - > input_rate = clk_hw_get_rate(clk_hw_get_parent(hw)); > > if (_get_table_rate(hw, &sel, pll->params->fixed_rate, input_rate)) > -- > 2.24.1 > Tested-by: Corentin Labbe <clabbe@baylibre.com> Thanks
03.06.2020 14:19, Thierry Reding пишет: > From: Thierry Reding <treding@nvidia.com> > > Commit bff1cef5f23a ("clk: tegra: Don't enable already enabled PLLs") > added checks to avoid enabling PLLs that have already been enabled by > the bootloader. However, the PLL_E configuration inherited from the > bootloader isn't necessarily the one that is needed for the kernel. > > This can cause SATA to fail like this: > > [ 5.310270] phy phy-sata.6: phy poweron failed --> -110 > [ 5.315604] tegra-ahci 70027000.sata: failed to power on AHCI controller: -110 > [ 5.323022] tegra-ahci: probe of 70027000.sata failed with error -110 > > Fix this by always programming the PLL_E. This ensures that any mis- > configuration by the bootloader will be overwritten by the kernel. > > Fixes: bff1cef5f23a ("clk: tegra: Don't enable already enabled PLLs") > Reported-by: LABBE Corentin <clabbe@baylibre.com> > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/clk/tegra/clk-pll.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c > index 583d2ac61e9e..b2d39a66f0fa 100644 > --- a/drivers/clk/tegra/clk-pll.c > +++ b/drivers/clk/tegra/clk-pll.c > @@ -1601,9 +1601,6 @@ static int clk_plle_tegra114_enable(struct clk_hw *hw) > unsigned long flags = 0; > unsigned long input_rate; > > - if (clk_pll_is_enabled(hw)) > - return 0; > - > input_rate = clk_hw_get_rate(clk_hw_get_parent(hw)); > > if (_get_table_rate(hw, &sel, pll->params->fixed_rate, input_rate)) > Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Quoting Thierry Reding (2020-06-03 04:19:23) > From: Thierry Reding <treding@nvidia.com> > > Commit bff1cef5f23a ("clk: tegra: Don't enable already enabled PLLs") > added checks to avoid enabling PLLs that have already been enabled by > the bootloader. However, the PLL_E configuration inherited from the > bootloader isn't necessarily the one that is needed for the kernel. > > This can cause SATA to fail like this: > > [ 5.310270] phy phy-sata.6: phy poweron failed --> -110 > [ 5.315604] tegra-ahci 70027000.sata: failed to power on AHCI controller: -110 > [ 5.323022] tegra-ahci: probe of 70027000.sata failed with error -110 > > Fix this by always programming the PLL_E. This ensures that any mis- > configuration by the bootloader will be overwritten by the kernel. > > Fixes: bff1cef5f23a ("clk: tegra: Don't enable already enabled PLLs") > Reported-by: LABBE Corentin <clabbe@baylibre.com> > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- Acked-by: Stephen Boyd <sboyd@kernel.org>
diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c index 583d2ac61e9e..b2d39a66f0fa 100644 --- a/drivers/clk/tegra/clk-pll.c +++ b/drivers/clk/tegra/clk-pll.c @@ -1601,9 +1601,6 @@ static int clk_plle_tegra114_enable(struct clk_hw *hw) unsigned long flags = 0; unsigned long input_rate; - if (clk_pll_is_enabled(hw)) - return 0; - input_rate = clk_hw_get_rate(clk_hw_get_parent(hw)); if (_get_table_rate(hw, &sel, pll->params->fixed_rate, input_rate))