| Message ID | 20180423095456.16697-1-digetx@gmail.com |
|---|---|
| State | Deferred |
| Headers | show |
| Series | [v1] gpu: host1x: Fix dma_free_wc() argument in the error path | expand |
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com> On 23.04.2018 12:54, Dmitry Osipenko wrote: > If IOVA allocation or IOMMU mapping fails, dma_free_wc() is invoked with > size=0 because of a typo, that triggers "kernel BUG at mm/vmalloc.c:124!". > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/gpu/host1x/cdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/host1x/cdma.c b/drivers/gpu/host1x/cdma.c > index 93df28228721..0724122afeac 100644 > --- a/drivers/gpu/host1x/cdma.c > +++ b/drivers/gpu/host1x/cdma.c > @@ -127,7 +127,7 @@ static int host1x_pushbuffer_init(struct push_buffer *pb) > iommu_free_iova: > __free_iova(&host1x->iova, alloc); > iommu_free_mem: > - dma_free_wc(host1x->dev, pb->alloc_size, pb->mapped, pb->phys); > + dma_free_wc(host1x->dev, size, pb->mapped, pb->phys); > > return err; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Apr 23, 2018 at 12:54:56PM +0300, Dmitry Osipenko wrote: > If IOVA allocation or IOMMU mapping fails, dma_free_wc() is invoked with > size=0 because of a typo, that triggers "kernel BUG at mm/vmalloc.c:124!". > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/gpu/host1x/cdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Thierry
diff --git a/drivers/gpu/host1x/cdma.c b/drivers/gpu/host1x/cdma.c index 93df28228721..0724122afeac 100644 --- a/drivers/gpu/host1x/cdma.c +++ b/drivers/gpu/host1x/cdma.c @@ -127,7 +127,7 @@ static int host1x_pushbuffer_init(struct push_buffer *pb) iommu_free_iova: __free_iova(&host1x->iova, alloc); iommu_free_mem: - dma_free_wc(host1x->dev, pb->alloc_size, pb->mapped, pb->phys); + dma_free_wc(host1x->dev, size, pb->mapped, pb->phys); return err; }
If IOVA allocation or IOMMU mapping fails, dma_free_wc() is invoked with size=0 because of a typo, that triggers "kernel BUG at mm/vmalloc.c:124!". Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/gpu/host1x/cdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)