From patchwork Mon Jul 24 14:55:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 792834 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="G/hyaAIP"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xGPZB6bBQz9s75 for ; Tue, 25 Jul 2017 00:55:46 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932367AbdGXOzn (ORCPT ); Mon, 24 Jul 2017 10:55:43 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:36051 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932289AbdGXOzL (ORCPT ); Mon, 24 Jul 2017 10:55:11 -0400 Received: by mail-wr0-f195.google.com with SMTP id y67so16855484wrb.3; Mon, 24 Jul 2017 07:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=yOKRWZynyQe29UDHBWl1L3Xy2x017RoQn0d9lEnOb24=; b=G/hyaAIPEIspS/QmcYf3VjHoyEn6i46Kd3YqlU4RKCC9uWvtxlc0F8hXWE/IRL5gIH 9EooovvvQp1G5Sh87kgXdI25QrC2GLIep7iWbvBhRrjhIMh9j/8/NO88M61+rEEPnREN r0pOQVDEpBx3Uwi5I6Pi/oA9bGs7eybMswoYztclHKUlEguGhclUxGikCZufv1JHfqXk bfet+O+UUdTbl1VwOOKpSR4/8FmGcyKzDT0C6tyKDNkgLR3ORVhKBC7VbJl+X6VTnPjr gm03ju7HQY57mPr6sr9vCv3aEQ1y5pvQN0/ni9HWSdlvAW3V5q4hZj4p+kDAQSNV07C5 5NTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yOKRWZynyQe29UDHBWl1L3Xy2x017RoQn0d9lEnOb24=; b=MoSyfxyyt6HyEBWt4L3L4fAa4qU14fhBcAX9eH0SXTXlYgp+Msrghl6QCwUtCe0cRF E8yb8cL0xwlqvrxl2Yfq0e09uieJmHDFqtoJmuFJAM78CeU4fjlOZTwM4vqjqnNqYPU/ htVvbaZsUq0Y17akO7AN3QesBt9sJRR6U4tHeNbM1DaxOcBvJyspHCt8z9RIICZnlNj3 SxkO76GkCzqFtJQ31KxS2pHCSxiTaxNztQjg84ky+DELN1PxW4vKgLAOddMU+kWVWPKW lvzD+85O2LtYl9HqWIZ3FJEhHn+9i3yEbQNvTTtGmE6Sh44Jd+PWFTHWYxwSQ1wtB0Lc GrNw== X-Gm-Message-State: AIVw110kRjUqh4vCOSwJhHi9jLvA38VnkayPLiUKy9hX0xjePaAwlil3 YVYAdGYsJpmqUQ== X-Received: by 10.223.134.39 with SMTP id 36mr12216200wrv.244.1500908110260; Mon, 24 Jul 2017 07:55:10 -0700 (PDT) Received: from localhost (p200300E41BDFF20076D02BFFFE273F51.dip0.t-ipconnect.de. [2003:e4:1bdf:f200:76d0:2bff:fe27:3f51]) by smtp.gmail.com with ESMTPSA id i185sm8782450wmf.34.2017.07.24.07.55.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Jul 2017 07:55:09 -0700 (PDT) From: Thierry Reding To: Linus Walleij Cc: Jonathan Hunter , linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] gpio: tegra: Remove unnecessary check Date: Mon, 24 Jul 2017 16:55:05 +0200 Message-Id: <20170724145508.7388-1-thierry.reding@gmail.com> X-Mailer: git-send-email 2.13.3 Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org From: Thierry Reding of_device_get_match_data() can never return NULL, therefore the check for NULL values is unnecessary. Signed-off-by: Thierry Reding Acked-by: Jon Hunter --- drivers/gpio/gpio-tegra.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c index 17725c83821f..63ee221f9be9 100644 --- a/drivers/gpio/gpio-tegra.c +++ b/drivers/gpio/gpio-tegra.c @@ -566,7 +566,6 @@ static struct lock_class_key gpio_lock_class; static int tegra_gpio_probe(struct platform_device *pdev) { - const struct tegra_gpio_soc_config *config; struct tegra_gpio_info *tgi; struct resource *res; struct tegra_gpio_bank *bank; @@ -575,17 +574,11 @@ static int tegra_gpio_probe(struct platform_device *pdev) int i; int j; - config = of_device_get_match_data(&pdev->dev); - if (!config) { - dev_err(&pdev->dev, "Error: No device match found\n"); - return -ENODEV; - } - tgi = devm_kzalloc(&pdev->dev, sizeof(*tgi), GFP_KERNEL); if (!tgi) return -ENODEV; - tgi->soc = config; + tgi->soc = of_device_get_match_data(&pdev->dev); tgi->dev = &pdev->dev; ret = platform_irq_count(pdev); @@ -625,7 +618,7 @@ static int tegra_gpio_probe(struct platform_device *pdev) platform_set_drvdata(pdev, tgi); - if (config->debounce_supported) + if (tgi->soc->debounce_supported) tgi->gc.set_config = tegra_gpio_set_config; tgi->bank_info = devm_kzalloc(&pdev->dev, tgi->bank_count *