diff mbox

[v2,6/6] ARM: tegra: nyan-blaze: Proper pinmux for TPM i2c

Message ID 20170122154753.31942-6-contact@paulk.fr
State Accepted
Headers show

Commit Message

Paul Kocialkowski Jan. 22, 2017, 3:47 p.m. UTC 
From: Jerome Coste <jerome.coste@etu.utc.fr>

This corrects the pinmux for accessing the TPM over the i2c line.
Thus, it allows correctly probing the module, that previously failed with i2c
errors.
---
 arch/arm/boot/dts/tegra124-nyan-blaze.dts | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

Thierry Reding Jan. 25, 2017, 11:09 a.m. UTC | #1 
On Sun, Jan 22, 2017 at 04:47:53PM +0100, Paul Kocialkowski wrote:
> From: Jerome Coste <jerome.coste@etu.utc.fr>
> 
> This corrects the pinmux for accessing the TPM over the i2c line.
> Thus, it allows correctly probing the module, that previously failed with i2c
> errors.

This is missing a Signed-off-by: from Jerome and you (since you
forwarded the patch). I've added those since I assume that that was
intended and your both willing to provide it.

Other than that, same substitution for "i2c" -> "I2C" as on 5/6, and
please also make sure this change gets into the pinmux configurations.

Thanks,
Thierry
diff mbox

Patch

diff --git a/arch/arm/boot/dts/tegra124-nyan-blaze.dts b/arch/arm/boot/dts/tegra124-nyan-blaze.dts
index aca0828115eb..9df25ca5ab83 100644
--- a/arch/arm/boot/dts/tegra124-nyan-blaze.dts
+++ b/arch/arm/boot/dts/tegra124-nyan-blaze.dts
@@ -1100,19 +1100,19 @@ 
 			};
 			cam_i2c_scl_pbb1 {
 				nvidia,pins = "cam_i2c_scl_pbb1";
-				nvidia,function = "rsvd3";
-				nvidia,pull = <TEGRA_PIN_PULL_DOWN>;
-				nvidia,tristate = <TEGRA_PIN_ENABLE>;
-				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,open-drain = <TEGRA_PIN_DISABLE>;
+				nvidia,function = "i2c3";
+				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
+				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 			cam_i2c_sda_pbb2 {
 				nvidia,pins = "cam_i2c_sda_pbb2";
-				nvidia,function = "rsvd3";
-				nvidia,pull = <TEGRA_PIN_PULL_DOWN>;
-				nvidia,tristate = <TEGRA_PIN_ENABLE>;
-				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,open-drain = <TEGRA_PIN_DISABLE>;
+				nvidia,function = "i2c3";
+				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
+				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 			pbb3 {
 				nvidia,pins = "pbb3";