From patchwork Sun Jul 3 17:30:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Gortmaker X-Patchwork-Id: 643798 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rjHLF2jB7z9t18 for ; Mon, 4 Jul 2016 03:33:25 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752958AbcGCRdB (ORCPT ); Sun, 3 Jul 2016 13:33:01 -0400 Received: from mail5.windriver.com ([192.103.53.11]:43403 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752885AbcGCRcn (ORCPT ); Sun, 3 Jul 2016 13:32:43 -0400 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id u63HWMon030378 (version=TLSv1 cipher=AES128-SHA bits=128 verify=OK); Sun, 3 Jul 2016 10:32:23 -0700 Received: from yow-lpgnfs-02.corp.ad.wrs.com (128.224.149.8) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.3.248.2; Sun, 3 Jul 2016 10:32:22 -0700 From: Paul Gortmaker To: CC: Paul Gortmaker , Stephen Warren , Thierry Reding , Alexandre Courbot , Jon Hunter , , Subject: [PATCH 3/4] bus: tegra-aconnect: make it explicitly non-modular Date: Sun, 3 Jul 2016 13:30:39 -0400 Message-ID: <20160703173040.23612-4-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.8.4 In-Reply-To: <20160703173040.23612-1-paul.gortmaker@windriver.com> References: <20160703173040.23612-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org The Kconfig currently controlling compilation of this code is: drivers/bus/Kconfig:config TEGRA_ACONNECT drivers/bus/Kconfig: bool "Tegra ACONNECT Bus Driver" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. We explicitly disallow a driver unbind, since that doesn't have a sensible use case anyway, and it allows us to drop the ".remove" code for non-modular drivers. Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit. Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. We also delete the MODULE_LICENSE tag etc. since all that information was (or is now) contained at the top of the file in the comments. Cc: Stephen Warren Cc: Thierry Reding Cc: Alexandre Courbot Cc: Jon Hunter Cc: linux-tegra@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Paul Gortmaker --- drivers/bus/tegra-aconnect.c | 22 +++++----------------- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/bus/tegra-aconnect.c b/drivers/bus/tegra-aconnect.c index 7e4104b74fa8..f3982946ab8a 100644 --- a/drivers/bus/tegra-aconnect.c +++ b/drivers/bus/tegra-aconnect.c @@ -1,6 +1,8 @@ /* * Tegra ACONNECT Bus Driver * + * Author: Jon Hunter + * * Copyright (C) 2016, NVIDIA CORPORATION. All rights reserved. * * This file is subject to the terms and conditions of the GNU General Public @@ -9,7 +11,7 @@ */ #include -#include +#include #include #include #include @@ -66,15 +68,6 @@ clk_destroy: return ret; } -static int tegra_aconnect_remove(struct platform_device *pdev) -{ - pm_runtime_disable(&pdev->dev); - - pm_clk_destroy(&pdev->dev); - - return 0; -} - static int tegra_aconnect_runtime_resume(struct device *dev) { return pm_clk_resume(dev); @@ -94,19 +87,14 @@ static const struct of_device_id tegra_aconnect_of_match[] = { { .compatible = "nvidia,tegra210-aconnect", }, { } }; -MODULE_DEVICE_TABLE(of, tegra_aconnect_of_match); static struct platform_driver tegra_aconnect_driver = { .probe = tegra_aconnect_probe, - .remove = tegra_aconnect_remove, .driver = { .name = "tegra-aconnect", + .suppress_bind_attrs = true, .of_match_table = tegra_aconnect_of_match, .pm = &tegra_aconnect_pm_ops, }, }; -module_platform_driver(tegra_aconnect_driver); - -MODULE_DESCRIPTION("NVIDIA Tegra ACONNECT Bus Driver"); -MODULE_AUTHOR("Jon Hunter "); -MODULE_LICENSE("GPL v2"); +builtin_platform_driver(tegra_aconnect_driver);