From patchwork Sun Jan 24 15:15:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amitoj Kaur Chawla X-Patchwork-Id: 572314 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8B2CA140B0E for ; Mon, 25 Jan 2016 02:16:11 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=mCpaqFTv; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752230AbcAXPPb (ORCPT ); Sun, 24 Jan 2016 10:15:31 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33558 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751954AbcAXPPa (ORCPT ); Sun, 24 Jan 2016 10:15:30 -0500 Received: by mail-pf0-f194.google.com with SMTP id e65so5750985pfe.0; Sun, 24 Jan 2016 07:15:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=BoxJT2pU8c4yKaDYXooX6LQQpXzmUJnRuP5QWt69FRY=; b=mCpaqFTvGjDH69hD6nNjckbMMXWo/m9nRHWO9WEmR/1klIG2luZ6ZhadxD+5LyNV+u mu+RVmicTmB6uOfHNgrIXrk3on5nyGNcKoLyHl8b837vv/FHYF7T2j6IJ4HuvGsAKvfH sVFxAzVnTf/Xr8MT7qvUziJflYQSlTpXQMmN4mgxTB/ZfGdMBcpEvQGGtmLMBLCOHrwr yLsvP6+YAnqphI3FCTshPSjLcPE5vt9ZEqLhW4SnhfpimFFv0E1mADsQMtUnFd9sjKjd LkVglpQSH1Co+q37fViPHEc56QyTlCoF6Hoh6E/9FK2MrFggpVCvf6GPSPXnzaqe29U+ o8fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-type:content-disposition:user-agent; bh=BoxJT2pU8c4yKaDYXooX6LQQpXzmUJnRuP5QWt69FRY=; b=kvhRxnBH65HXoo5oyIg3Gfvvw8ZnmgmY4lFEtyfZ8F3WMV8D8GwXT1JTJQpi680V5T R7MxJxU7FYujJFsBQ9NeumUqoxQ5LaO6/MKxum++He0mTmnFKJzL59UbC9KayS/KAJas rHqDLeYilORQ9v8GsQ3Wfqcbqku37jABhIOvlO8xh5dcUgz63REqJvkw1j2DnAAovcoY yOkJWLIQHvEneo9HtLEq1u7IMVwOtqPIVncijFyy3s2rlslP5TZTYKV94bFSXNRni7pl 51CDYm8HuydL3tQ8uG+MUfnNyAJtcFO6WSzzKNqbrs2fHIE48QgXQU6RX7XJ2wSUKbq/ kNTw== X-Gm-Message-State: AG10YOQKwaBzhxKHSgiok91of/BOi42lkE9Y2VGXvkKbkfJ02F27BRgWAfOXQrAQiq+mdQ== X-Received: by 10.98.72.132 with SMTP id q4mr18904051pfi.53.1453648529813; Sun, 24 Jan 2016 07:15:29 -0800 (PST) Received: from localhost ([110.227.143.170]) by smtp.gmail.com with ESMTPSA id qz9sm22311747pab.39.2016.01.24.07.15.27 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 24 Jan 2016 07:15:29 -0800 (PST) Date: Sun, 24 Jan 2016 20:45:20 +0530 From: Amitoj Kaur Chawla To: pdeschrijver@nvidia.com, pgaikwad@nvidia.com, mturquette@baylibre.com, sboyd@codeaurora.org, swarren@wwwdotorg.org, thierry.reding@gmail.com, gnurou@gmail.com, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Cc: julia.lawall@lip6.fr Subject: [PATCH] clk: tegra: clk-emc: Add missing of_node_put Message-ID: <20160124151519.GA23923@amitoj-Inspiron-3542> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org for_each_child_of_node performs an of_node_get on each iteration, so to break out of the loop an of_node_put is required. Found using Coccinelle. The semantic patch used for this is as follows: // @@ expression e; local idexpression child; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child ( return child; | + of_node_put(child); ? return ...; ) ... } // Signed-off-by: Amitoj Kaur Chawla --- drivers/clk/tegra/clk-emc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/clk/tegra/clk-emc.c b/drivers/clk/tegra/clk-emc.c index 138a94b..6aaccf9 100644 --- a/drivers/clk/tegra/clk-emc.c +++ b/drivers/clk/tegra/clk-emc.c @@ -450,8 +450,10 @@ static int load_timings_from_dt(struct tegra_clk_emc *tegra, struct emc_timing *timing = tegra->timings + (i++); err = load_one_timing_from_dt(tegra, timing, child); - if (err) + if (err) { + of_node_put(child); return err; + } timing->ram_code = ram_code; } @@ -501,9 +503,9 @@ struct clk *tegra_clk_register_emc(void __iomem *base, struct device_node *np, * fuses until the apbmisc driver is loaded. */ err = load_timings_from_dt(tegra, node, node_ram_code); + of_node_put(node); if (err) return ERR_PTR(err); - of_node_put(node); break; }