| Message ID | 1617900043-10506-2-git-send-email-skomatineni@nvidia.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v1] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present | expand |
08.04.2021 19:40, Sowjanya Komatineni пишет: > This patch adds a check on present of PM domain and calls legacy power > domain API tegra_powergate_power_off() only when PM domain is not present. > > This is a follow-up patch to Tegra186 AHCI support patch series > https://lore.kernel.org/patchwork/cover/1408752/ > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > > --- > drivers/ata/ahci_tegra.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c > index 56612af..bd484dd 100644 > --- a/drivers/ata/ahci_tegra.c > +++ b/drivers/ata/ahci_tegra.c > @@ -287,7 +287,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv) > reset_control_assert(tegra->sata_cold_rst); > > clk_disable_unprepare(tegra->sata_clk); > - tegra_powergate_power_off(TEGRA_POWERGATE_SATA); > + if (!tegra->pdev->dev.pm_domain) > + tegra_powergate_power_off(TEGRA_POWERGATE_SATA); > > regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies); > } > There are two instances of tegra_powergate_power_off() in the driver.
On 4/8/21 12:58 PM, Dmitry Osipenko wrote: > 08.04.2021 19:40, Sowjanya Komatineni пишет: >> This patch adds a check on present of PM domain and calls legacy power >> domain API tegra_powergate_power_off() only when PM domain is not present. >> >> This is a follow-up patch to Tegra186 AHCI support patch series >> https://lore.kernel.org/patchwork/cover/1408752/ >> >> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> >> >> --- >> drivers/ata/ahci_tegra.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c >> index 56612af..bd484dd 100644 >> --- a/drivers/ata/ahci_tegra.c >> +++ b/drivers/ata/ahci_tegra.c >> @@ -287,7 +287,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv) >> reset_control_assert(tegra->sata_cold_rst); >> >> clk_disable_unprepare(tegra->sata_clk); >> - tegra_powergate_power_off(TEGRA_POWERGATE_SATA); >> + if (!tegra->pdev->dev.pm_domain) >> + tegra_powergate_power_off(TEGRA_POWERGATE_SATA); >> >> regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies); >> } >> > There are two instances of tegra_powergate_power_off() in the driver. Thanks Dmitry. Sorry missed it. Will fix
diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c index 56612af..bd484dd 100644 --- a/drivers/ata/ahci_tegra.c +++ b/drivers/ata/ahci_tegra.c @@ -287,7 +287,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv) reset_control_assert(tegra->sata_cold_rst); clk_disable_unprepare(tegra->sata_clk); - tegra_powergate_power_off(TEGRA_POWERGATE_SATA); + if (!tegra->pdev->dev.pm_domain) + tegra_powergate_power_off(TEGRA_POWERGATE_SATA); regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies); }
This patch adds a check on present of PM domain and calls legacy power domain API tegra_powergate_power_off() only when PM domain is not present. This is a follow-up patch to Tegra186 AHCI support patch series https://lore.kernel.org/patchwork/cover/1408752/ Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> --- drivers/ata/ahci_tegra.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)