| Message ID | 1612684970-125948-1-git-send-email-jiapeng.chong@linux.alibaba.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v2] memory: tegra186-emc: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE | expand |
On Sun, 7 Feb 2021 at 09:03, Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote: > > Fix the following coccicheck warning: > > drivers/memory/tegra/tegra186-emc.c:158:0-23: WARNING: > tegra186_emc_debug_max_rate_fops should be defined with > DEFINE_DEBUGFS_ATTRIBUTE. > > drivers/memory/tegra/tegra186-emc.c:128:0-23: WARNING: > tegra186_emc_debug_min_rate_fops should be defined with > DEFINE_DEBUGFS_ATTRIBUTE. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> Hi, My question from v1 is still valid because I did not receive any coccinelle report - where can we find it? Best regards, Krzysztof
On Sun, 7 Feb 2021 16:02:50 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > drivers/memory/tegra/tegra186-emc.c:158:0-23: WARNING: > tegra186_emc_debug_max_rate_fops should be defined with > DEFINE_DEBUGFS_ATTRIBUTE. > > drivers/memory/tegra/tegra186-emc.c:128:0-23: WARNING: > tegra186_emc_debug_min_rate_fops should be defined with > DEFINE_DEBUGFS_ATTRIBUTE. Applied, thanks! [1/1] memory: tegra186-emc: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE commit: 321b36c79c431957c8c599a9f9640096c305cd03 Best regards,
diff --git a/drivers/memory/tegra/tegra186-emc.c b/drivers/memory/tegra/tegra186-emc.c index fa8af17..d65e7c2 100644 --- a/drivers/memory/tegra/tegra186-emc.c +++ b/drivers/memory/tegra/tegra186-emc.c @@ -125,9 +125,9 @@ static int tegra186_emc_debug_min_rate_set(void *data, u64 rate) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(tegra186_emc_debug_min_rate_fops, - tegra186_emc_debug_min_rate_get, - tegra186_emc_debug_min_rate_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(tegra186_emc_debug_min_rate_fops, + tegra186_emc_debug_min_rate_get, + tegra186_emc_debug_min_rate_set, "%llu\n"); static int tegra186_emc_debug_max_rate_get(void *data, u64 *rate) { @@ -155,9 +155,9 @@ static int tegra186_emc_debug_max_rate_set(void *data, u64 rate) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(tegra186_emc_debug_max_rate_fops, - tegra186_emc_debug_max_rate_get, - tegra186_emc_debug_max_rate_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(tegra186_emc_debug_max_rate_fops, + tegra186_emc_debug_max_rate_get, + tegra186_emc_debug_max_rate_set, "%llu\n"); static int tegra186_emc_probe(struct platform_device *pdev) {
Fix the following coccicheck warning: drivers/memory/tegra/tegra186-emc.c:158:0-23: WARNING: tegra186_emc_debug_max_rate_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE. drivers/memory/tegra/tegra186-emc.c:128:0-23: WARNING: tegra186_emc_debug_min_rate_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- Changes in v2: - Stripped unrelated parts of the paths (./). drivers/memory/tegra/tegra186-emc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)