| Message ID | 1552513552-23423-5-git-send-email-skomatineni@nvidia.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [V3,01/10] mmc: tegra: fix ddr signaling for non-ddr modes | expand |
On Wed, 13 Mar 2019 at 22:45, Sowjanya Komatineni <skomatineni@nvidia.com> wrote: > > Default tap and trim values are incorrect for Tegra186 SDMMC4. > This patch fixes it. > > Tested-by: Jon Hunter <jonathanh@nvidia.com> > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> Is this a fix and/or for stable? In either case, I am leaving this for arm-soc. Kind regards Uffe > --- > arch/arm64/boot/dts/nvidia/tegra186.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > index 97aeb946ed5e..472f55fe9488 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > @@ -317,8 +317,8 @@ > nvidia,pad-autocal-pull-down-offset-1v8-timeout = <0x0a>; > nvidia,pad-autocal-pull-up-offset-3v3-timeout = <0x0a>; > nvidia,pad-autocal-pull-down-offset-3v3-timeout = <0x0a>; > - nvidia,default-tap = <0x5>; > - nvidia,default-trim = <0x9>; > + nvidia,default-tap = <0x9>; > + nvidia,default-trim = <0x5>; > nvidia,dqs-trim = <63>; > mmc-hs400-1_8v; > status = "disabled"; > -- > 2.7.4 >
> > > > Default tap and trim values are incorrect for Tegra186 SDMMC4. > > This patch fixes it. > > > > Tested-by: Jon Hunter <jonathanh@nvidia.com> > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > > Is this a fix and/or for stable? > > In either case, I am leaving this for arm-soc. > > Kind regards > Uffe > Thanks Uffe. Yes this is applicable for stable. > > --- > > arch/arm64/boot/dts/nvidia/tegra186.dtsi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > index 97aeb946ed5e..472f55fe9488 100644 > > --- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > +++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > @@ -317,8 +317,8 @@ > > nvidia,pad-autocal-pull-down-offset-1v8-timeout = <0x0a>; > > nvidia,pad-autocal-pull-up-offset-3v3-timeout = <0x0a>; > > nvidia,pad-autocal-pull-down-offset-3v3-timeout = <0x0a>; > > - nvidia,default-tap = <0x5>; > > - nvidia,default-trim = <0x9>; > > + nvidia,default-tap = <0x9>; > > + nvidia,default-trim = <0x5>; > > nvidia,dqs-trim = <63>; > > mmc-hs400-1_8v; > > status = "disabled"; > > -- > > 2.7.4 > >
> > > > > > Default tap and trim values are incorrect for Tegra186 SDMMC4. > > > This patch fixes it. > > > > > > Tested-by: Jon Hunter <jonathanh@nvidia.com> > > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > > > > Is this a fix and/or for stable? > > > > In either case, I am leaving this for arm-soc. > > > > Kind regards > > Uffe > > > > Thanks Uffe. Yes this is applicable for stable. I don’t see any confirmation of this being applied by arm-soc. So thought to re-check if this is applied? > > > --- > > > arch/arm64/boot/dts/nvidia/tegra186.dtsi | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > > b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > > index 97aeb946ed5e..472f55fe9488 100644 > > > --- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > > +++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > > @@ -317,8 +317,8 @@ > > > nvidia,pad-autocal-pull-down-offset-1v8-timeout = <0x0a>; > > > nvidia,pad-autocal-pull-up-offset-3v3-timeout = <0x0a>; > > > nvidia,pad-autocal-pull-down-offset-3v3-timeout = <0x0a>; > > > - nvidia,default-tap = <0x5>; > > > - nvidia,default-trim = <0x9>; > > > + nvidia,default-tap = <0x9>; > > > + nvidia,default-trim = <0x5>; > > > nvidia,dqs-trim = <63>; > > > mmc-hs400-1_8v; > > > status = "disabled"; > > > -- > > > 2.7.4 > > >
On Mon, 1 Apr 2019 at 19:43, Sowjanya Komatineni <skomatineni@nvidia.com> wrote: > > > > > > > > > Default tap and trim values are incorrect for Tegra186 SDMMC4. > > > > This patch fixes it. > > > > > > > > Tested-by: Jon Hunter <jonathanh@nvidia.com> > > > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > > > > > > Is this a fix and/or for stable? > > > > > > In either case, I am leaving this for arm-soc. > > > > > > Kind regards > > > Uffe > > > > > > > Thanks Uffe. Yes this is applicable for stable. > > I don’t see any confirmation of this being applied by arm-soc. > So thought to re-check if this is applied? Perhaps repost it to remind the soc maintainer to pick it up. Kind regards Uffe > > > > > --- > > > > arch/arm64/boot/dts/nvidia/tegra186.dtsi | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > > > b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > > > index 97aeb946ed5e..472f55fe9488 100644 > > > > --- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > > > +++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > > > @@ -317,8 +317,8 @@ > > > > nvidia,pad-autocal-pull-down-offset-1v8-timeout = <0x0a>; > > > > nvidia,pad-autocal-pull-up-offset-3v3-timeout = <0x0a>; > > > > nvidia,pad-autocal-pull-down-offset-3v3-timeout = <0x0a>; > > > > - nvidia,default-tap = <0x5>; > > > > - nvidia,default-trim = <0x9>; > > > > + nvidia,default-tap = <0x9>; > > > > + nvidia,default-trim = <0x5>; > > > > nvidia,dqs-trim = <63>; > > > > mmc-hs400-1_8v; > > > > status = "disabled"; > > > > -- > > > > 2.7.4 > > > >
> On Mon, 1 Apr 2019 at 19:43, Sowjanya Komatineni <skomatineni@nvidia.com> wrote: > > > > > > > > > > > > Default tap and trim values are incorrect for Tegra186 SDMMC4. > > > > > This patch fixes it. > > > > > > > > > > Tested-by: Jon Hunter <jonathanh@nvidia.com> > > > > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > > > > > > > > Is this a fix and/or for stable? > > > > > > > > In either case, I am leaving this for arm-soc. > > > > > > > > Kind regards > > > > Uffe > > > > > > > > > > Thanks Uffe. Yes this is applicable for stable. > > > > I don’t see any confirmation of this being applied by arm-soc. > > So thought to re-check if this is applied? > > Perhaps repost it to remind the soc maintainer to pick it up. > > Kind regards > Uffe > Reposted patch 5 and 10 in this series that are waiting for soc maintainers as fresh individual patches. Thanks Sowjanya > > > > > > > --- > > > > > arch/arm64/boot/dts/nvidia/tegra186.dtsi | 4 ++-- > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > > > > b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > > > > index 97aeb946ed5e..472f55fe9488 100644 > > > > > --- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > > > > +++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > > > > > @@ -317,8 +317,8 @@ > > > > > nvidia,pad-autocal-pull-down-offset-1v8-timeout = <0x0a>; > > > > > nvidia,pad-autocal-pull-up-offset-3v3-timeout = <0x0a>; > > > > > nvidia,pad-autocal-pull-down-offset-3v3-timeout = <0x0a>; > > > > > - nvidia,default-tap = <0x5>; > > > > > - nvidia,default-trim = <0x9>; > > > > > + nvidia,default-tap = <0x9>; > > > > > + nvidia,default-trim = <0x5>; > > > > > nvidia,dqs-trim = <63>; > > > > > mmc-hs400-1_8v; > > > > > status = "disabled"; > > > > > -- > > > > > 2.7.4 > > > > >
diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi index 97aeb946ed5e..472f55fe9488 100644 --- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi @@ -317,8 +317,8 @@ nvidia,pad-autocal-pull-down-offset-1v8-timeout = <0x0a>; nvidia,pad-autocal-pull-up-offset-3v3-timeout = <0x0a>; nvidia,pad-autocal-pull-down-offset-3v3-timeout = <0x0a>; - nvidia,default-tap = <0x5>; - nvidia,default-trim = <0x9>; + nvidia,default-tap = <0x9>; + nvidia,default-trim = <0x5>; nvidia,dqs-trim = <63>; mmc-hs400-1_8v; status = "disabled";