| Message ID | 1550551825-1245-1-git-send-email-skomatineni@nvidia.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [V4,1/2] i2c: tegra: remove master fifo support on tegra186 | expand |
On Mon, Feb 18, 2019 at 08:50:24PM -0800, Sowjanya Komatineni wrote: > Tegra186 does not have master fifo control register and instead > uses fifo control register like prior tegra chipset. > > This patch fixes this and prevents crashing during boot when > accessing fifo control registers. > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > --- > drivers/i2c/busses/i2c-tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Nit: fifo -> FIFO, tegra -> Tegra, but other than that: Acked-by: Thierry Reding <treding@nvidia.com> A quick note on why I'm pointing out these capitalization issues so pedantically: specifically in the "tegra" case, it's difficult to grep for it because it matches things like "integration", which is a surprisingly common word in the kernel. Spelling it "Tegra" consistently make it easier to grep for Tegra related bits specifically. Thierry > diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c > index a4cd79c9f7a7..e6851904acc1 100644 > --- a/drivers/i2c/busses/i2c-tegra.c > +++ b/drivers/i2c/busses/i2c-tegra.c > @@ -1436,7 +1436,7 @@ static const struct tegra_i2c_hw_feature tegra186_i2c_hw = { > .has_config_load_reg = true, > .has_multi_master_mode = true, > .has_slcg_override_reg = true, > - .has_mst_fifo = true, > + .has_mst_fifo = false, > .quirks = &tegra_i2c_quirks, > .supports_bus_clear = true, > .has_apb_dma = false, > -- > 2.7.4 >
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index a4cd79c9f7a7..e6851904acc1 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -1436,7 +1436,7 @@ static const struct tegra_i2c_hw_feature tegra186_i2c_hw = { .has_config_load_reg = true, .has_multi_master_mode = true, .has_slcg_override_reg = true, - .has_mst_fifo = true, + .has_mst_fifo = false, .quirks = &tegra_i2c_quirks, .supports_bus_clear = true, .has_apb_dma = false,
Tegra186 does not have master fifo control register and instead uses fifo control register like prior tegra chipset. This patch fixes this and prevents crashing during boot when accessing fifo control registers. Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> --- drivers/i2c/busses/i2c-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)