| Message ID | 1544732743-11106-1-git-send-email-skomatineni@nvidia.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [V1] mmc: tegra: Fix for SDMMC pads autocal parsing from dt | expand |
On 13/12/18 10:25 PM, Sowjanya Komatineni wrote: > Some of the SDMMC pads auto calibration values parsed from > devicetree are assigned incorrectly. This patch fixes it. > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci-tegra.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index 7b95d088fdef..e6ace31e2a41 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -510,25 +510,25 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-up-offset-3v3-timeout", > - &autocal->pull_up_3v3); > + &autocal->pull_up_3v3_timeout); > if (err) > autocal->pull_up_3v3_timeout = 0; > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-down-offset-3v3-timeout", > - &autocal->pull_down_3v3); > + &autocal->pull_down_3v3_timeout); > if (err) > autocal->pull_down_3v3_timeout = 0; > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-up-offset-1v8-timeout", > - &autocal->pull_up_1v8); > + &autocal->pull_up_1v8_timeout); > if (err) > autocal->pull_up_1v8_timeout = 0; > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-down-offset-1v8-timeout", > - &autocal->pull_down_1v8); > + &autocal->pull_down_1v8_timeout); > if (err) > autocal->pull_down_1v8_timeout = 0; > >
On Thu, Dec 13, 2018 at 12:25:43PM -0800, Sowjanya Komatineni wrote: > Some of the SDMMC pads auto calibration values parsed from > devicetree are assigned incorrectly. This patch fixes it. > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> > --- > drivers/mmc/host/sdhci-tegra.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Acked-by: Thierry Reding <treding@nvidia.com>
On Thu, 13 Dec 2018 at 21:25, Sowjanya Komatineni <skomatineni@nvidia.com> wrote: > > Some of the SDMMC pads auto calibration values parsed from > devicetree are assigned incorrectly. This patch fixes it. > > Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> Applied for fixes and added a fixes tag, thanks! Fixes: 51b77c8ea784 ("mmc: tegra: Program pad autocal offsets from dt") Kind regards Uffe > --- > drivers/mmc/host/sdhci-tegra.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index 7b95d088fdef..e6ace31e2a41 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -510,25 +510,25 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-up-offset-3v3-timeout", > - &autocal->pull_up_3v3); > + &autocal->pull_up_3v3_timeout); > if (err) > autocal->pull_up_3v3_timeout = 0; > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-down-offset-3v3-timeout", > - &autocal->pull_down_3v3); > + &autocal->pull_down_3v3_timeout); > if (err) > autocal->pull_down_3v3_timeout = 0; > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-up-offset-1v8-timeout", > - &autocal->pull_up_1v8); > + &autocal->pull_up_1v8_timeout); > if (err) > autocal->pull_up_1v8_timeout = 0; > > err = device_property_read_u32(host->mmc->parent, > "nvidia,pad-autocal-pull-down-offset-1v8-timeout", > - &autocal->pull_down_1v8); > + &autocal->pull_down_1v8_timeout); > if (err) > autocal->pull_down_1v8_timeout = 0; > > -- > 2.7.4 >
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c index 7b95d088fdef..e6ace31e2a41 100644 --- a/drivers/mmc/host/sdhci-tegra.c +++ b/drivers/mmc/host/sdhci-tegra.c @@ -510,25 +510,25 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host) err = device_property_read_u32(host->mmc->parent, "nvidia,pad-autocal-pull-up-offset-3v3-timeout", - &autocal->pull_up_3v3); + &autocal->pull_up_3v3_timeout); if (err) autocal->pull_up_3v3_timeout = 0; err = device_property_read_u32(host->mmc->parent, "nvidia,pad-autocal-pull-down-offset-3v3-timeout", - &autocal->pull_down_3v3); + &autocal->pull_down_3v3_timeout); if (err) autocal->pull_down_3v3_timeout = 0; err = device_property_read_u32(host->mmc->parent, "nvidia,pad-autocal-pull-up-offset-1v8-timeout", - &autocal->pull_up_1v8); + &autocal->pull_up_1v8_timeout); if (err) autocal->pull_up_1v8_timeout = 0; err = device_property_read_u32(host->mmc->parent, "nvidia,pad-autocal-pull-down-offset-1v8-timeout", - &autocal->pull_down_1v8); + &autocal->pull_down_1v8_timeout); if (err) autocal->pull_down_1v8_timeout = 0;
Some of the SDMMC pads auto calibration values parsed from devicetree are assigned incorrectly. This patch fixes it. Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> --- drivers/mmc/host/sdhci-tegra.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)