| Message ID | 1533650404-18125-4-git-send-email-avienamo@nvidia.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Tegra SDHCI support HS400 on Tegra210 and Tegra186 | expand |
On Tue, Aug 07, 2018 at 04:59:59PM +0300, Aapo Vienamo wrote: > Implement HS400 enhanced strobe. Can you provide a little more information about what the impact is of this? Does this increase throughput? How much? > > Signed-off-by: Aapo Vienamo <avienamo@nvidia.com> > --- > drivers/mmc/host/sdhci-tegra.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index 426f7ea..d81143b 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -43,6 +43,9 @@ > #define SDHCI_CLOCK_CTRL_PADPIPE_CLKEN_OVERRIDE BIT(3) > #define SDHCI_CLOCK_CTRL_SPI_MODE_CLKEN_OVERRIDE BIT(2) > > +#define SDHCI_TEGRA_VENDOR_SYS_SW_CTRL 0x104 > +#define SDHCI_TEGRA_SYS_SW_CTRL_ENHANCED_STROBE BIT(31) > + > #define SDHCI_TEGRA_VENDOR_CAP_OVERRIDES 0x10c > #define SDHCI_TEGRA_CAP_OVERRIDES_DQS_TRIM_MASK 0x00003f00 > #define SDHCI_TEGRA_CAP_OVERRIDES_DQS_TRIM_SHIFT 8 > @@ -271,6 +274,22 @@ static void tegra_sdhci_set_tap(struct sdhci_host *host, unsigned int tap) > } > } > > +static void tegra_sdhci_hs400_enhanced_strobe(struct mmc_host *mmc, > + struct mmc_ios *ios) > +{ > + struct sdhci_host *host = mmc_priv(mmc); > + u32 reg; > + > + reg = sdhci_readl(host, SDHCI_TEGRA_VENDOR_SYS_SW_CTRL); > + pr_err("enhanced strobe: %d\n", ios->enhanced_strobe); Left-over debug error? > + if (ios->enhanced_strobe) > + reg |= SDHCI_TEGRA_SYS_SW_CTRL_ENHANCED_STROBE; > + else > + reg &= ~SDHCI_TEGRA_SYS_SW_CTRL_ENHANCED_STROBE; > + sdhci_writel(host, reg, SDHCI_TEGRA_VENDOR_SYS_SW_CTRL); You might want to add blank lines around the if ... else ... block for readability. Thierry
On Thu, 9 Aug 2018 13:43:45 +0200 Thierry Reding <thierry.reding@gmail.com> wrote: > On Tue, Aug 07, 2018 at 04:59:59PM +0300, Aapo Vienamo wrote: > > Implement HS400 enhanced strobe. > > Can you provide a little more information about what the impact is of > this? Does this increase throughput? How much? The eMMC enhanced strobe is a mechanism that can be used instead of the HS400 tuning procedure. Note that the delay line calibration implemented later on in this series is Tegra specific and has to be performed regardless of which type of HS400 tuning mechanism is used. > > > > Signed-off-by: Aapo Vienamo <avienamo@nvidia.com> > > --- > > drivers/mmc/host/sdhci-tegra.c | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > > index 426f7ea..d81143b 100644 > > --- a/drivers/mmc/host/sdhci-tegra.c > > +++ b/drivers/mmc/host/sdhci-tegra.c > > @@ -43,6 +43,9 @@ > > #define SDHCI_CLOCK_CTRL_PADPIPE_CLKEN_OVERRIDE BIT(3) > > #define SDHCI_CLOCK_CTRL_SPI_MODE_CLKEN_OVERRIDE BIT(2) > > > > +#define SDHCI_TEGRA_VENDOR_SYS_SW_CTRL 0x104 > > +#define SDHCI_TEGRA_SYS_SW_CTRL_ENHANCED_STROBE BIT(31) > > + > > #define SDHCI_TEGRA_VENDOR_CAP_OVERRIDES 0x10c > > #define SDHCI_TEGRA_CAP_OVERRIDES_DQS_TRIM_MASK 0x00003f00 > > #define SDHCI_TEGRA_CAP_OVERRIDES_DQS_TRIM_SHIFT 8 > > @@ -271,6 +274,22 @@ static void tegra_sdhci_set_tap(struct sdhci_host *host, unsigned int tap) > > } > > } > > > > +static void tegra_sdhci_hs400_enhanced_strobe(struct mmc_host *mmc, > > + struct mmc_ios *ios) > > +{ > > + struct sdhci_host *host = mmc_priv(mmc); > > + u32 reg; > > + > > + reg = sdhci_readl(host, SDHCI_TEGRA_VENDOR_SYS_SW_CTRL); > > + pr_err("enhanced strobe: %d\n", ios->enhanced_strobe); > > Left-over debug error? Yep. > > > + if (ios->enhanced_strobe) > > + reg |= SDHCI_TEGRA_SYS_SW_CTRL_ENHANCED_STROBE; > > + else > > + reg &= ~SDHCI_TEGRA_SYS_SW_CTRL_ENHANCED_STROBE; > > + sdhci_writel(host, reg, SDHCI_TEGRA_VENDOR_SYS_SW_CTRL); > > You might want to add blank lines around the if ... else ... block for > readability. True. -Aapo -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Aug 09, 2018 at 03:22:54PM +0300, Aapo Vienamo wrote: > On Thu, 9 Aug 2018 13:43:45 +0200 > Thierry Reding <thierry.reding@gmail.com> wrote: > > > On Tue, Aug 07, 2018 at 04:59:59PM +0300, Aapo Vienamo wrote: > > > Implement HS400 enhanced strobe. > > > > Can you provide a little more information about what the impact is of > > this? Does this increase throughput? How much? > > The eMMC enhanced strobe is a mechanism that can be used instead of the > HS400 tuning procedure. Note that the delay line calibration implemented > later on in this series is Tegra specific and has to be performed > regardless of which type of HS400 tuning mechanism is used. Sounds like a variation of that would be good material for the commit message. Thierry
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c index 426f7ea..d81143b 100644 --- a/drivers/mmc/host/sdhci-tegra.c +++ b/drivers/mmc/host/sdhci-tegra.c @@ -43,6 +43,9 @@ #define SDHCI_CLOCK_CTRL_PADPIPE_CLKEN_OVERRIDE BIT(3) #define SDHCI_CLOCK_CTRL_SPI_MODE_CLKEN_OVERRIDE BIT(2) +#define SDHCI_TEGRA_VENDOR_SYS_SW_CTRL 0x104 +#define SDHCI_TEGRA_SYS_SW_CTRL_ENHANCED_STROBE BIT(31) + #define SDHCI_TEGRA_VENDOR_CAP_OVERRIDES 0x10c #define SDHCI_TEGRA_CAP_OVERRIDES_DQS_TRIM_MASK 0x00003f00 #define SDHCI_TEGRA_CAP_OVERRIDES_DQS_TRIM_SHIFT 8 @@ -271,6 +274,22 @@ static void tegra_sdhci_set_tap(struct sdhci_host *host, unsigned int tap) } } +static void tegra_sdhci_hs400_enhanced_strobe(struct mmc_host *mmc, + struct mmc_ios *ios) +{ + struct sdhci_host *host = mmc_priv(mmc); + u32 reg; + + reg = sdhci_readl(host, SDHCI_TEGRA_VENDOR_SYS_SW_CTRL); + pr_err("enhanced strobe: %d\n", ios->enhanced_strobe); + if (ios->enhanced_strobe) + reg |= SDHCI_TEGRA_SYS_SW_CTRL_ENHANCED_STROBE; + else + reg &= ~SDHCI_TEGRA_SYS_SW_CTRL_ENHANCED_STROBE; + sdhci_writel(host, reg, SDHCI_TEGRA_VENDOR_SYS_SW_CTRL); + +} + static void tegra_sdhci_reset(struct sdhci_host *host, u8 mask) { struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -947,6 +966,9 @@ static int sdhci_tegra_probe(struct platform_device *pdev) sdhci_tegra_start_signal_voltage_switch; } + host->mmc_host_ops.hs400_enhanced_strobe = + tegra_sdhci_hs400_enhanced_strobe; + rc = mmc_of_parse(host->mmc); if (rc) goto err_parse_dt;
Implement HS400 enhanced strobe. Signed-off-by: Aapo Vienamo <avienamo@nvidia.com> --- drivers/mmc/host/sdhci-tegra.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)