| Message ID | 1511907502-11528-1-git-send-email-gomonovych@gmail.com |
|---|---|
| State | Deferred |
| Headers | show |
| Series | drm/tegra: gem: Use PTR_ERR_OR_ZERO() | expand |
On 29.11.2017 00:18, Vasyl Gomonovych wrote: > Fix ptr_ret.cocci warnings: > drivers/gpu/drm/tegra/gem.c:420:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com> > --- > drivers/gpu/drm/tegra/gem.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c > index ab1e53d434e8..a40148cd0957 100644 > --- a/drivers/gpu/drm/tegra/gem.c > +++ b/drivers/gpu/drm/tegra/gem.c > @@ -417,10 +417,8 @@ int tegra_bo_dumb_create(struct drm_file *file, struct drm_device *drm, > > bo = tegra_bo_create_with_handle(file, drm, args->size, 0, > &args->handle); > - if (IS_ERR(bo)) > - return PTR_ERR(bo); > > - return 0; > + return PTR_ERR_OR_ZERO(bo); This is semantically less clear - the current code clearly has error and success paths while the changed code doesn't. Same for the other patch. Cheers, Mikko > } > > static int tegra_bo_fault(struct vm_fault *vmf) > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c index ab1e53d434e8..a40148cd0957 100644 --- a/drivers/gpu/drm/tegra/gem.c +++ b/drivers/gpu/drm/tegra/gem.c @@ -417,10 +417,8 @@ int tegra_bo_dumb_create(struct drm_file *file, struct drm_device *drm, bo = tegra_bo_create_with_handle(file, drm, args->size, 0, &args->handle); - if (IS_ERR(bo)) - return PTR_ERR(bo); - return 0; + return PTR_ERR_OR_ZERO(bo); } static int tegra_bo_fault(struct vm_fault *vmf)
Fix ptr_ret.cocci warnings: drivers/gpu/drm/tegra/gem.c:420:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com> --- drivers/gpu/drm/tegra/gem.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)