From patchwork Thu Jun 30 10:56:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Hunter X-Patchwork-Id: 642479 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rgGhg0x10z9sBG for ; Thu, 30 Jun 2016 20:57:23 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752109AbcF3K4g (ORCPT ); Thu, 30 Jun 2016 06:56:36 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:13083 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752062AbcF3K4e (ORCPT ); Thu, 30 Jun 2016 06:56:34 -0400 Received: from hqnvupgp08.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com id ; Thu, 30 Jun 2016 03:56:21 -0700 Received: from HQHUB102.nvidia.com ([172.20.187.25]) by hqnvupgp08.nvidia.com (PGP Universal service); Thu, 30 Jun 2016 03:55:16 -0700 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Thu, 30 Jun 2016 03:55:16 -0700 Received: from HQMAIL112.nvidia.com (172.18.146.18) by HQHUB102.nvidia.com (172.20.187.25) with Microsoft SMTP Server (TLS) id 8.3.406.0; Thu, 30 Jun 2016 03:56:33 -0700 Received: from HQMAIL104.nvidia.com (172.18.146.11) by HQMAIL112.nvidia.com (172.18.146.18) with Microsoft SMTP Server (TLS) id 15.0.1130.7; Thu, 30 Jun 2016 10:56:33 +0000 Received: from hqnvemgw02.nvidia.com (172.16.227.111) by HQMAIL104.nvidia.com (172.18.146.11) with Microsoft SMTP Server id 15.0.1130.7 via Frontend Transport; Thu, 30 Jun 2016 10:56:33 +0000 Received: from jonathanh-lm.nvidia.com (Not Verified[10.21.132.149]) by hqnvemgw02.nvidia.com with Trustwave SEG (v7,5,5,8150) id ; Thu, 30 Jun 2016 03:56:33 -0700 From: Jon Hunter To: Stephen Warren , Thierry Reding , Alexandre Courbot CC: , , Jon Hunter Subject: [PATCH 1/4] soc/tegra: pmc: Add specific error messages for initialising a powergate Date: Thu, 30 Jun 2016 11:56:24 +0100 Message-ID: <1467284187-13320-2-git-send-email-jonathanh@nvidia.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1467284187-13320-1-git-send-email-jonathanh@nvidia.com> References: <1467284187-13320-1-git-send-email-jonathanh@nvidia.com> X-NVConfidentiality: public MIME-Version: 1.0 Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org When initialising a powergate, only a single error message is shown if the initialisation fails. Add more error messages to give specific details of what failed if the initialisation failed and remove the generic failure message. Signed-off-by: Jon Hunter --- drivers/soc/tegra/pmc.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index 1f702538f8ec..df61c85e75c7 100644 --- a/drivers/soc/tegra/pmc.c +++ b/drivers/soc/tegra/pmc.c @@ -793,11 +793,13 @@ static void tegra_powergate_add(struct tegra_pmc *pmc, struct device_node *np) pg = kzalloc(sizeof(*pg), GFP_KERNEL); if (!pg) - goto error; + return; id = tegra_powergate_lookup(pmc, np->name); - if (id < 0) + if (id < 0) { + dev_err(pmc->dev, "powergate lookup failed for %s\n", np->name); goto free_mem; + } /* * Clear the bit for this powergate so it cannot be managed @@ -813,16 +815,23 @@ static void tegra_powergate_add(struct tegra_pmc *pmc, struct device_node *np) off = !tegra_powergate_is_powered(pg->id); - if (tegra_powergate_of_get_clks(pg, np)) + if (tegra_powergate_of_get_clks(pg, np)) { + dev_err(pmc->dev, "failed to get clocks for %s\n", np->name); goto set_available; + } - if (tegra_powergate_of_get_resets(pg, np, off)) + if (tegra_powergate_of_get_resets(pg, np, off)) { + dev_err(pmc->dev, "failed to get resets for %s\n", np->name); goto remove_clks; + } pm_genpd_init(&pg->genpd, NULL, off); - if (of_genpd_add_provider_simple(np, &pg->genpd)) + if (of_genpd_add_provider_simple(np, &pg->genpd)) { + dev_err(pmc->dev, "failed to add genpd provider for %s\n", + np->name); goto remove_resets; + } dev_dbg(pmc->dev, "added power domain %s\n", pg->genpd.name); @@ -843,9 +852,6 @@ set_available: free_mem: kfree(pg); - -error: - dev_err(pmc->dev, "failed to create power domain for %s\n", np->name); } static void tegra_powergate_init(struct tegra_pmc *pmc)