diff mbox

[v2,11/11] clk: tegra: WARN if clk in the init_table has enable

Message ID 1464381494-27096-12-git-send-email-rklein@nvidia.com
State Deferred
Headers show

Commit Message

Rhyland Klein May 27, 2016, 8:38 p.m. UTC
Enabling clocks through the init_table mechanism is deprecated. Clocks
that need to be enabled early and stay on should be marked as CRITICAL.

Signed-off-by: Rhyland Klein <rklein@nvidia.com>
 drivers/clk/tegra/clk.c | 5 +++++
 1 file changed, 5 insertions(+)
diff mbox


diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c
index b2cdd9a235f4..898fe922c742 100644
--- a/drivers/clk/tegra/clk.c
+++ b/drivers/clk/tegra/clk.c
@@ -262,6 +262,11 @@  void __init tegra_init_from_table(struct tegra_clk_init_table *tbl,
+		/* Using the init_table to enable clks at boot is
+		 * deprecated. Clks that need to be enabled through early
+		 * boot, they should be marked as CLK_IS_CRITICAL
+		 */
+		WARN_ON_ONCE(tbl->state);
 		if (tbl->state)
 			if (clk_prepare_enable(clk)) {
 				pr_err("%s: Failed to enable %s\n", __func__,