| Message ID | 1456501724-28477-11-git-send-email-jonathanh@nvidia.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Fri, Feb 26, 2016 at 03:48:44PM +0000, Jon Hunter wrote: > Add the audio power-domain for tegra210. Note that this also removes the > existing "#power-domain-cells" which was incorrectly included by > commit e53095857166 ("arm64: tegra: Add Tegra210 support"). > > Signed-off-by: Jon Hunter <jonathanh@nvidia.com> > > --- > > So far I have only added the audio power-domain for tegra210 as this is > what I have been testing with to date. However, once this series is > accepted then we can begin to add more. > > arch/arm64/boot/dts/nvidia/tegra210.dtsi | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) I'm slightly reluctant to apply this, since the domain isn't used anywhere. I'm assuming it will be used by the audio driver that you've been working on, but if that's not going to be merged this cycle, we'd end up with an unused label. Not that that's invalid in any way, but my rule of thumb has been not to introduce labels until they are used. Therefore I suggest we postpone this to the series that adds audio support. Thierry
On 29/02/16 07:30, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Fri, Feb 26, 2016 at 03:48:44PM +0000, Jon Hunter wrote: >> Add the audio power-domain for tegra210. Note that this also removes the >> existing "#power-domain-cells" which was incorrectly included by >> commit e53095857166 ("arm64: tegra: Add Tegra210 support"). >> >> Signed-off-by: Jon Hunter <jonathanh@nvidia.com> >> >> --- >> >> So far I have only added the audio power-domain for tegra210 as this is >> what I have been testing with to date. However, once this series is >> accepted then we can begin to add more. >> >> arch/arm64/boot/dts/nvidia/tegra210.dtsi | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) > > I'm slightly reluctant to apply this, since the domain isn't used > anywhere. I'm assuming it will be used by the audio driver that you've > been working on, but if that's not going to be merged this cycle, we'd > end up with an unused label. Not that that's invalid in any way, but my > rule of thumb has been not to introduce labels until they are used. > > Therefore I suggest we postpone this to the series that adds audio > support. That's fine with me or I can drop the label, until it is used by a device? Jon -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Feb 29, 2016 at 10:41:50AM +0000, Jon Hunter wrote: > > > On 29/02/16 07:30, Thierry Reding wrote: > > * PGP Signed by an unknown key > > > > On Fri, Feb 26, 2016 at 03:48:44PM +0000, Jon Hunter wrote: > >> Add the audio power-domain for tegra210. Note that this also removes the > >> existing "#power-domain-cells" which was incorrectly included by > >> commit e53095857166 ("arm64: tegra: Add Tegra210 support"). > >> > >> Signed-off-by: Jon Hunter <jonathanh@nvidia.com> > >> > >> --- > >> > >> So far I have only added the audio power-domain for tegra210 as this is > >> what I have been testing with to date. However, once this series is > >> accepted then we can begin to add more. > >> > >> arch/arm64/boot/dts/nvidia/tegra210.dtsi | 14 +++++++++++++- > >> 1 file changed, 13 insertions(+), 1 deletion(-) > > > > I'm slightly reluctant to apply this, since the domain isn't used > > anywhere. I'm assuming it will be used by the audio driver that you've > > been working on, but if that's not going to be merged this cycle, we'd > > end up with an unused label. Not that that's invalid in any way, but my > > rule of thumb has been not to introduce labels until they are used. > > > > Therefore I suggest we postpone this to the series that adds audio > > support. > > That's fine with me or I can drop the label, until it is used by a device? I'd prefer the former, no use in having anything in device tree that we're not using anyway. Unless we need this somehow to automatically turn off the domain at boot, in which case it might make more sense to add all others as well. Thierry
diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi index cd4f45ccd6a7..d2b6bb4eb202 100644 --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi @@ -2,6 +2,7 @@ #include <dt-bindings/gpio/tegra-gpio.h> #include <dt-bindings/memory/tegra210-mc.h> #include <dt-bindings/pinctrl/pinctrl-tegra.h> +#include <dt-bindings/power/tegra-powergate.h> #include <dt-bindings/interrupt-controller/arm-gic.h> / { @@ -581,7 +582,18 @@ clocks = <&tegra_car TEGRA210_CLK_PCLK>, <&clk32k_in>; clock-names = "pclk", "clk32k_in"; - #power-domain-cells = <1>; + powergates { + #address-cells = <1>; + #size-cells = <0>; + + pd_audio: aud { + reg = <TEGRA_POWERGATE_AUD>; + clocks = <&tegra_car TEGRA210_CLK_APE>, + <&tegra_car TEGRA210_CLK_APB2APE>; + resets = <&tegra_car 198>; + #power-domain-cells = <0>; + }; + }; }; fuse@0,7000f800 {
Add the audio power-domain for tegra210. Note that this also removes the existing "#power-domain-cells" which was incorrectly included by commit e53095857166 ("arm64: tegra: Add Tegra210 support"). Signed-off-by: Jon Hunter <jonathanh@nvidia.com> --- So far I have only added the audio power-domain for tegra210 as this is what I have been testing with to date. However, once this series is accepted then we can begin to add more. arch/arm64/boot/dts/nvidia/tegra210.dtsi | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)