diff mbox

[flasher,scripts] Fix "typo" in comment re: padding calculations

Message ID 1439925257-22522-1-git-send-email-swarren@wwwdotorg.org
State Deferred
Headers show

Commit Message

Stephen Warren Aug. 18, 2015, 7:14 p.m. UTC 
From: Stephen Warren <swarren@nvidia.com>

The binary format is U-Boot code + DTB + pad + flash image. U-Boot moves
the DTB out of the way of BSS. The pad is to prevent U-Boot trashing the
flash image, not the DTB. Fix the comment to reflect that.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 tegra-uboot-flasher | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Warren Aug. 19, 2015, 4:57 p.m. UTC | #1 
On 08/18/2015 01:14 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> The binary format is U-Boot code + DTB + pad + flash image. U-Boot moves
> the DTB out of the way of BSS. The pad is to prevent U-Boot trashing the
> flash image, not the DTB. Fix the comment to reflect that.

Patch is applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tegra-uboot-flasher b/tegra-uboot-flasher
index 4809665d4a6a..d20e3ad413ef 100755
--- a/tegra-uboot-flasher
+++ b/tegra-uboot-flasher
@@ -160,7 +160,7 @@  def func_flash():
     if args.debug:
         print 'bss_size %d 0x%x' % (bss_size, bss_size)
 
-    # Avoid U-Boot's BSS, so the BSS-zeroing doesn't trash the DTB
+    # Avoid U-Boot's BSS, so the BSS-zeroing doesn't trash the appended flash image
     # Add 4KB in case the DTB size changes due to fdtput
     # Align to 4k, so flash writes don't need a bounce buffer for DMA
     padded_size = (u_boot_plus_dtb_size + bss_size + (2 * 4 * 1024) - 1) & ~((4 * 1024) - 1)