From patchwork Mon May 4 17:36:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Bresticker X-Patchwork-Id: 467758 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 054971402A0 for ; Tue, 5 May 2015 03:37:11 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751403AbbEDRhF (ORCPT ); Mon, 4 May 2015 13:37:05 -0400 Received: from mail-pa0-f73.google.com ([209.85.220.73]:33044 "EHLO mail-pa0-f73.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088AbbEDRgv (ORCPT ); Mon, 4 May 2015 13:36:51 -0400 Received: by pablj1 with SMTP id lj1so12800844pab.0 for ; Mon, 04 May 2015 10:36:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PhX4YjBuXpwOFEUf513BNuPqJGfZDfV53R06ICZnD/Y=; b=RkPq+oJrWDeWlH+hD81AAyMitUW6hqt+nHUk8NlTZdjPMyrxLQwci3nDv6MwVFHTH0 ZTx3jdYJtL2g2jGYh9Gb36TnhFRUeIa28JSYJ17MVrF8XCtbfyTCqxDlhecVL44i65xX hmor6yoyxruND6Q31ZGRukSlIDF3Hh+HHgbgPSCS/79PivjrK/1Wff2eyPNrL5qIUOt4 HiGId02ZvxP+xBeSSn+n8UJv58n5SWPepA03PXqm3B6hqM0Ljqj2W8WUw5fraEpHu10X DU9EVVl5X2tyYkXam47yKTUu3ALWcu2cijwhIIV0l6tskBgWlhScHl1EF+rC7ue98Z0X OLKg== X-Gm-Message-State: ALoCoQnGceCOlk5N7Y3c6DsIneWX/pshzkTfqV/DGqNeLGjTqfdBfcukpPUJmS09tQtsODOJ0m7l X-Received: by 10.66.190.36 with SMTP id gn4mr40879891pac.17.1430761010351; Mon, 04 May 2015 10:36:50 -0700 (PDT) Received: from corpmail-nozzle1-2.hot.corp.google.com ([100.108.1.103]) by gmr-mx.google.com with ESMTPS id o5si726865yhd.5.2015.05.04.10.36.49 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 May 2015 10:36:50 -0700 (PDT) Received: from abrestic.mtv.corp.google.com ([172.22.65.70]) by corpmail-nozzle1-2.hot.corp.google.com with ESMTP id ZOJ2t7JD.1; Mon, 04 May 2015 10:36:50 -0700 Received: by abrestic.mtv.corp.google.com (Postfix, from userid 137652) id BD546A4919; Mon, 4 May 2015 10:36:48 -0700 (PDT) From: Andrew Bresticker To: Stephen Warren , Thierry Reding , Alexandre Courbot Cc: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Bresticker , Jon Hunter , Jassi Brar , Suman Anna , Ashwin Chaugule , Ley Foon Tan Subject: [PATCH v8 2/9] mailbox: Make mbox_chan_ops const Date: Mon, 4 May 2015 10:36:35 -0700 Message-Id: <1430761002-9327-3-git-send-email-abrestic@chromium.org> X-Mailer: git-send-email 2.2.0.rc0.207.ga3a616c In-Reply-To: <1430761002-9327-1-git-send-email-abrestic@chromium.org> References: <1430761002-9327-1-git-send-email-abrestic@chromium.org> Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org The mailbox controller's channel ops ought to be read-only. Update all the mailbox drivers to make their mbox_chan_ops const as well. Signed-off-by: Andrew Bresticker Cc: Jassi Brar Cc: Suman Anna Cc: Ashwin Chaugule Cc: Ley Foon Tan Acked-by: Suman Anna --- Changes from v7: - Constify all drivers' mbox_chan_ops. No changes from v5/v6. New for v5. --- drivers/mailbox/arm_mhu.c | 2 +- drivers/mailbox/mailbox-altera.c | 2 +- drivers/mailbox/omap-mailbox.c | 2 +- drivers/mailbox/pcc.c | 2 +- include/linux/mailbox_controller.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mailbox/arm_mhu.c b/drivers/mailbox/arm_mhu.c index ac693c6..d9e99f9 100644 --- a/drivers/mailbox/arm_mhu.c +++ b/drivers/mailbox/arm_mhu.c @@ -110,7 +110,7 @@ static void mhu_shutdown(struct mbox_chan *chan) free_irq(mlink->irq, chan); } -static struct mbox_chan_ops mhu_ops = { +static const struct mbox_chan_ops mhu_ops = { .send_data = mhu_send_data, .startup = mhu_startup, .shutdown = mhu_shutdown, diff --git a/drivers/mailbox/mailbox-altera.c b/drivers/mailbox/mailbox-altera.c index a266265..bb682c9 100644 --- a/drivers/mailbox/mailbox-altera.c +++ b/drivers/mailbox/mailbox-altera.c @@ -285,7 +285,7 @@ static void altera_mbox_shutdown(struct mbox_chan *chan) } } -static struct mbox_chan_ops altera_mbox_ops = { +static const struct mbox_chan_ops altera_mbox_ops = { .send_data = altera_mbox_send_data, .startup = altera_mbox_startup, .shutdown = altera_mbox_shutdown, diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c index 0f332c1..03f8545 100644 --- a/drivers/mailbox/omap-mailbox.c +++ b/drivers/mailbox/omap-mailbox.c @@ -604,7 +604,7 @@ static int omap_mbox_chan_send_data(struct mbox_chan *chan, void *data) return ret; } -static struct mbox_chan_ops omap_mbox_chan_ops = { +static const struct mbox_chan_ops omap_mbox_chan_ops = { .startup = omap_mbox_chan_startup, .send_data = omap_mbox_chan_send_data, .shutdown = omap_mbox_chan_shutdown, diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c index 7e91d68..26d121d 100644 --- a/drivers/mailbox/pcc.c +++ b/drivers/mailbox/pcc.c @@ -198,7 +198,7 @@ static int pcc_send_data(struct mbox_chan *chan, void *data) return 0; } -static struct mbox_chan_ops pcc_chan_ops = { +static const struct mbox_chan_ops pcc_chan_ops = { .send_data = pcc_send_data, }; diff --git a/include/linux/mailbox_controller.h b/include/linux/mailbox_controller.h index d4cf96f..68c4245 100644 --- a/include/linux/mailbox_controller.h +++ b/include/linux/mailbox_controller.h @@ -72,7 +72,7 @@ struct mbox_chan_ops { */ struct mbox_controller { struct device *dev; - struct mbox_chan_ops *ops; + const struct mbox_chan_ops *ops; struct mbox_chan *chans; int num_chans; bool txdone_irq;