Message ID | 1363252089-4120-1-git-send-email-hdoyu@nvidia.com |
---|---|
State | Not Applicable, archived |
Headers | show |
On Thu, Mar 14, 2013 at 11:08:09AM +0200, Hiroshi Doyu wrote: > Make this depend on CONFIG_PM. This protection is necessary to not > cause any build errors with any combination of PM features especially > when supporting a new SoC where each PM features are being enabled > one-by-one during its depelopment. > > Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com> > Reported-by: Joseph Lo <josephl@nvidia.com> > --- > drivers/amba/tegra-ahb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/amba/tegra-ahb.c b/drivers/amba/tegra-ahb.c > index 093c435..1f44e56 100644 > --- a/drivers/amba/tegra-ahb.c > +++ b/drivers/amba/tegra-ahb.c > @@ -158,7 +158,7 @@ int tegra_ahb_enable_smmu(struct device_node *dn) > EXPORT_SYMBOL(tegra_ahb_enable_smmu); > #endif > > -#ifdef CONFIG_PM_SLEEP > +#ifdef CONFIG_PM > static int tegra_ahb_suspend(struct device *dev) > { > int i; Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
On 03/14/2013 03:08 AM, Hiroshi Doyu wrote: > Make this depend on CONFIG_PM. This protection is necessary to not > cause any build errors with any combination of PM features especially > when supporting a new SoC where each PM features are being enabled > one-by-one during its depelopment. Looks fine to me. Acked-by: Stephen Warren <swarren@nvidia.com> I assume Russell will want this to go through his patch tracker. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Stephen Warren <swarren@wwwdotorg.org> wrote @ Fri, 15 Mar 2013 06:23:38 +0100: > On 03/14/2013 03:08 AM, Hiroshi Doyu wrote: > > Make this depend on CONFIG_PM. This protection is necessary to not > > cause any build errors with any combination of PM features especially > > when supporting a new SoC where each PM features are being enabled > > one-by-one during its depelopment. > > Looks fine to me. > > Acked-by: Stephen Warren <swarren@nvidia.com> > > I assume Russell will want this to go through his patch tracker. FYI: Patch has been accepted as patch 7675/1 -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/amba/tegra-ahb.c b/drivers/amba/tegra-ahb.c index 093c435..1f44e56 100644 --- a/drivers/amba/tegra-ahb.c +++ b/drivers/amba/tegra-ahb.c @@ -158,7 +158,7 @@ int tegra_ahb_enable_smmu(struct device_node *dn) EXPORT_SYMBOL(tegra_ahb_enable_smmu); #endif -#ifdef CONFIG_PM_SLEEP +#ifdef CONFIG_PM static int tegra_ahb_suspend(struct device *dev) { int i;
Make this depend on CONFIG_PM. This protection is necessary to not cause any build errors with any combination of PM features especially when supporting a new SoC where each PM features are being enabled one-by-one during its depelopment. Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com> Reported-by: Joseph Lo <josephl@nvidia.com> --- drivers/amba/tegra-ahb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)