| Message ID | 1353020646-14867-1-git-send-email-ldewangan@nvidia.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Fri, Nov 16, 2012 at 12:04 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote: > Read the output value when gpio is set for the output mode for > gpio_get_value(). Reading input value in direction out does not > give correct value. > > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > Acked-by: Stephen Warren <swarren@nvidia.com> > --- > Changes from V1: > - Keep the if part implementation same the else part to have implementation > same kind. > > Not too old patchi but just resending in case of it is missed. > Adding acked by Stephen as he acked this patch. This patch was already applied in my tree... sorry no clue why you haven't seen it? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c index c7c175a..1163cf1 100644 --- a/drivers/gpio/gpio-tegra.c +++ b/drivers/gpio/gpio-tegra.c @@ -135,6 +135,11 @@ static void tegra_gpio_set(struct gpio_chip *chip, unsigned offset, int value) static int tegra_gpio_get(struct gpio_chip *chip, unsigned offset) { + /* If gpio is in output mode then read from the out value */ + if ((tegra_gpio_readl(GPIO_OE(offset)) >> GPIO_BIT(offset)) & 1) + return (tegra_gpio_readl(GPIO_OUT(offset)) >> + GPIO_BIT(offset)) & 0x1; + return (tegra_gpio_readl(GPIO_IN(offset)) >> GPIO_BIT(offset)) & 0x1; }