| Message ID | 1336030889-32269-2-git-send-email-ldewangan@nvidia.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Thu, 2012-05-03 at 13:11 +0530, Laxman Dewangan wrote: > The dma controller like Nvidia's Tegra Dma controller > supports the different slave requestor id from different slave. > This need to be configure in dma controller to handle the request > properly. > > Adding the slave-id in the slave configuration so that information > can be passed from client when configuring for slave. > > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > --- > > This change is require to get rid of tegra_dma header to pass the > slave requestor id. > > include/linux/dmaengine.h | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h > index 1082698..b0b275f 100644 > --- a/include/linux/dmaengine.h > +++ b/include/linux/dmaengine.h > @@ -338,6 +338,9 @@ enum dma_slave_buswidth { > * @device_fc: Flow Controller Settings. Only valid for slave channels. Fill > * with 'true' if peripheral should be flow controller. Direction will be > * selected at Runtime. > + * @slave_id: Slave requester id. Only valid for slave channels. The dma > + * slave peripheral will have unique id as dma requester which need to be > + * pass as slave config. > * > * This struct is passed in as configuration data to a DMA engine > * in order to set up a certain channel for DMA transport at runtime. > @@ -365,6 +368,7 @@ struct dma_slave_config { > u32 src_maxburst; > u32 dst_maxburst; > bool device_fc; > + int slave_id; This wont be negative, so perhaps an unsigned value? > }; > > static inline const char *dma_chan_name(struct dma_chan *chan)
Thanks for review. On Wednesday 09 May 2012 02:19 PM, Vinod Koul wrote: > On Thu, 2012-05-03 at 13:11 +0530, Laxman Dewangan wrote: >> The dma controller like Nvidia's Tegra Dma controller >> supports the different slave requestor id from different slave. >> This need to be configure in dma controller to handle the request >> properly. >> >> Adding the slave-id in the slave configuration so that information >> can be passed from client when configuring for slave. >> >> u32 dst_maxburst; >> bool device_fc; >> + int slave_id; > This wont be negative, so perhaps an unsigned value? Fine, I will make it unsigned int in my next patch. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index 1082698..b0b275f 100644 --- a/include/linux/dmaengine.h +++ b/include/linux/dmaengine.h @@ -338,6 +338,9 @@ enum dma_slave_buswidth { * @device_fc: Flow Controller Settings. Only valid for slave channels. Fill * with 'true' if peripheral should be flow controller. Direction will be * selected at Runtime. + * @slave_id: Slave requester id. Only valid for slave channels. The dma + * slave peripheral will have unique id as dma requester which need to be + * pass as slave config. * * This struct is passed in as configuration data to a DMA engine * in order to set up a certain channel for DMA transport at runtime. @@ -365,6 +368,7 @@ struct dma_slave_config { u32 src_maxburst; u32 dst_maxburst; bool device_fc; + int slave_id; }; static inline const char *dma_chan_name(struct dma_chan *chan)
The dma controller like Nvidia's Tegra Dma controller supports the different slave requestor id from different slave. This need to be configure in dma controller to handle the request properly. Adding the slave-id in the slave configuration so that information can be passed from client when configuring for slave. Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> --- This change is require to get rid of tegra_dma header to pass the slave requestor id. include/linux/dmaengine.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)