diff mbox

[V2,2/4] staging: iio: light: of: Fix vendor prefix of isl29018/isl29028

Message ID 1335183097-21104-4-git-send-email-ldewangan@nvidia.com
State Not Applicable, archived
Headers show

Commit Message

Laxman Dewangan April 23, 2012, 12:11 p.m. UTC
ISL29018/ISL29028 is from Intersil Corporation and making the
vendor prefix for this part as "isil" for OF compatibity.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
Changes from V1:
- Vendor prefix is now "isil"

 drivers/staging/iio/light/isl29018.c |    2 +-
 drivers/staging/iio/light/isl29028.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Stephen Warren April 23, 2012, 5:17 p.m. UTC | #1
On 04/23/2012 06:11 AM, Laxman Dewangan wrote:
> ISL29018/ISL29028 is from Intersil Corporation and making the
> vendor prefix for this part as "isil" for OF compatibity.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>

I assume this patch will go through the staging tree. Let me know if you
want me to take it through the Tegra tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
gregkh@linuxfoundation.org April 23, 2012, 5:28 p.m. UTC | #2
On Mon, Apr 23, 2012 at 11:17:19AM -0600, Stephen Warren wrote:
> On 04/23/2012 06:11 AM, Laxman Dewangan wrote:
> > ISL29018/ISL29028 is from Intersil Corporation and making the
> > vendor prefix for this part as "isil" for OF compatibity.
> > 
> > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> 
> I assume this patch will go through the staging tree. Let me know if you
> want me to take it through the Tegra tree.

Please take it through the Tegra tree, it is probably easier overall
that way:
	Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Warren April 23, 2012, 5:43 p.m. UTC | #3
On 04/23/2012 11:28 AM, Greg KH wrote:
> On Mon, Apr 23, 2012 at 11:17:19AM -0600, Stephen Warren wrote:
>> On 04/23/2012 06:11 AM, Laxman Dewangan wrote:
>>> ISL29018/ISL29028 is from Intersil Corporation and making the
>>> vendor prefix for this part as "isil" for OF compatibity.
>>>
>>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>>
>> I assume this patch will go through the staging tree. Let me know if you
>> want me to take it through the Tegra tree.
> 
> Please take it through the Tegra tree, it is probably easier overall
> that way:
> 	Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Sorry, looking harder, this patch touches a file that's added in the
current staging tree, so I can't take this patch.

There aren't any dependencies between this patch and the others due to
the way I2C probing works (the OF vendor prefix ends up getting
ignored), so I think merging it into staging should be simple.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
gregkh@linuxfoundation.org April 23, 2012, 5:49 p.m. UTC | #4
On Mon, Apr 23, 2012 at 11:43:55AM -0600, Stephen Warren wrote:
> On 04/23/2012 11:28 AM, Greg KH wrote:
> > On Mon, Apr 23, 2012 at 11:17:19AM -0600, Stephen Warren wrote:
> >> On 04/23/2012 06:11 AM, Laxman Dewangan wrote:
> >>> ISL29018/ISL29028 is from Intersil Corporation and making the
> >>> vendor prefix for this part as "isil" for OF compatibity.
> >>>
> >>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> >>
> >> I assume this patch will go through the staging tree. Let me know if you
> >> want me to take it through the Tegra tree.
> > 
> > Please take it through the Tegra tree, it is probably easier overall
> > that way:
> > 	Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Sorry, looking harder, this patch touches a file that's added in the
> current staging tree, so I can't take this patch.
> 
> There aren't any dependencies between this patch and the others due to
> the way I2C probing works (the OF vendor prefix ends up getting
> ignored), so I think merging it into staging should be simple.

Ok, I'll do that, Laxman, can you resend it to me?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Laxman Dewangan April 24, 2012, 6:13 a.m. UTC | #5
On Monday 23 April 2012 11:19 PM, Greg KH wrote:
> On Mon, Apr 23, 2012 at 11:43:55AM -0600, Stephen Warren wrote:
>> On 04/23/2012 11:28 AM, Greg KH wrote:
>>> On Mon, Apr 23, 2012 at 11:17:19AM -0600, Stephen Warren wrote:
>>>> On 04/23/2012 06:11 AM, Laxman Dewangan wrote:
>>>>> ISL29018/ISL29028 is from Intersil Corporation and making the
>>>>> vendor prefix for this part as "isil" for OF compatibity.
>>>>>
>>>>> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
>>>> I assume this patch will go through the staging tree. Let me know if you
>>>> want me to take it through the Tegra tree.
>>> Please take it through the Tegra tree, it is probably easier overall
>>> that way:
>>> 	Acked-by: Greg Kroah-Hartman<gregkh@linuxfoundation.org>
>> Sorry, looking harder, this patch touches a file that's added in the
>> current staging tree, so I can't take this patch.
>>
>> There aren't any dependencies between this patch and the others due to
>> the way I2C probing works (the OF vendor prefix ends up getting
>> ignored), so I think merging it into staging should be simple.
> Ok, I'll do that, Laxman, can you resend it to me?
>

Resend  the patch. Removed the 2/4 in subject to remove dependency as it 
can go independently.

Thanks,
Laxman
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
index 073e899..1ec2dac 100644
--- a/drivers/staging/iio/light/isl29018.c
+++ b/drivers/staging/iio/light/isl29018.c
@@ -596,7 +596,7 @@  static const struct i2c_device_id isl29018_id[] = {
 MODULE_DEVICE_TABLE(i2c, isl29018_id);
 
 static const struct of_device_id isl29018_of_match[] = {
-	{ .compatible = "invn,isl29018", },
+	{ .compatible = "isil,isl29018", },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, isl29018_of_match);
diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
index 4ac49aa..7057d9b 100644
--- a/drivers/staging/iio/light/isl29028.c
+++ b/drivers/staging/iio/light/isl29028.c
@@ -542,7 +542,7 @@  static const struct i2c_device_id isl29028_id[] = {
 MODULE_DEVICE_TABLE(i2c, isl29028_id);
 
 static const struct of_device_id isl29028_of_match[] = {
-	{ .compatible = "isl,isl29028", },
+	{ .compatible = "isil,isl29028", },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, isl29028_of_match);