diff mbox

[1/8] ARM: tegra: export tegra_gpio_{en,dis}able

Message ID 1330630010-11241-2-git-send-email-alan@signal11.us
State Superseded, archived
Headers show

Commit Message

Alan Ott March 1, 2012, 7:26 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de>

These two functions are used in drivers that can be
modules, so they need to be exported.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpio/gpio-tegra.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Olof Johansson March 1, 2012, 7:59 p.m. UTC | #1
Hi,

On Thu, Mar 1, 2012 at 11:26 AM, Alan Ott <alan@signal11.us> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> These two functions are used in drivers that can be
> modules, so they need to be exported.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

With some of the pinmux changes going in this will no longer be
needed, but it is for now so:

Acked-by: Olof Johansson <olof@lixom.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Grant Likely March 2, 2012, 7:24 a.m. UTC | #2
On Thu,  1 Mar 2012 14:26:43 -0500, Alan Ott <alan@signal11.us> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> These two functions are used in drivers that can be
> modules, so they need to be exported.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Grant Likely <grant.likely@secretlab.ca>

> ---
>  drivers/gpio/gpio-tegra.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> index bdc2937..96662cc 100644
> --- a/drivers/gpio/gpio-tegra.c
> +++ b/drivers/gpio/gpio-tegra.c
> @@ -107,11 +107,13 @@ void tegra_gpio_enable(int gpio)
>  {
>  	tegra_gpio_mask_write(GPIO_MSK_CNF(gpio), gpio, 1);
>  }
> +EXPORT_SYMBOL_GPL(tegra_gpio_enable);
>  
>  void tegra_gpio_disable(int gpio)
>  {
>  	tegra_gpio_mask_write(GPIO_MSK_CNF(gpio), gpio, 0);
>  }
> +EXPORT_SYMBOL_GPL(tegra_gpio_disable);
>  
>  static void tegra_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
>  {
> -- 
> 1.7.0.4
>
Stephen Warren March 9, 2012, 5:09 p.m. UTC | #3
On 03/09/2012 10:00 AM, Alan Ott wrote:
> On 03/02/2012 05:32 PM, Alan Ott wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> These two functions are used in drivers that can be
>> modules, so they need to be exported.
>>
>> Acked-by: Grant Likely <grant.likely@secretlab.ca>
>> Acked-by: Olof Johansson <olof@lixom.net>
...
> Did this patch ever get picked up into someone's tree?

It looks like Grant ack'd it which implies the thought Olof was going to
take it through the Tegra tree perhaps? But Olof did the same, so is
probably waiting for Grant to take it...
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Grant Likely March 12, 2012, 5:43 p.m. UTC | #4
On Fri, 09 Mar 2012 10:09:57 -0700, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 03/09/2012 10:00 AM, Alan Ott wrote:
> > On 03/02/2012 05:32 PM, Alan Ott wrote:
> >> From: Arnd Bergmann <arnd@arndb.de>
> >>
> >> These two functions are used in drivers that can be
> >> modules, so they need to be exported.
> >>
> >> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> >> Acked-by: Olof Johansson <olof@lixom.net>
> ...
> > Did this patch ever get picked up into someone's tree?
> 
> It looks like Grant ack'd it which implies the thought Olof was going to
> take it through the Tegra tree perhaps? But Olof did the same, so is
> probably waiting for Grant to take it...

Applied, thx.

g.
diff mbox

Patch

diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index bdc2937..96662cc 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -107,11 +107,13 @@  void tegra_gpio_enable(int gpio)
 {
 	tegra_gpio_mask_write(GPIO_MSK_CNF(gpio), gpio, 1);
 }
+EXPORT_SYMBOL_GPL(tegra_gpio_enable);
 
 void tegra_gpio_disable(int gpio)
 {
 	tegra_gpio_mask_write(GPIO_MSK_CNF(gpio), gpio, 0);
 }
+EXPORT_SYMBOL_GPL(tegra_gpio_disable);
 
 static void tegra_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
 {