From patchwork Sat Feb 4 00:10:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Warren X-Patchwork-Id: 139494 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id CCBC0104792 for ; Sat, 4 Feb 2012 11:10:41 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754387Ab2BDAKf (ORCPT ); Fri, 3 Feb 2012 19:10:35 -0500 Received: from hqemgate03.nvidia.com ([216.228.121.140]:19924 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754116Ab2BDAKV (ORCPT ); Fri, 3 Feb 2012 19:10:21 -0500 Received: from hqnvupgp06.nvidia.com (Not Verified[216.228.121.13]) by hqemgate03.nvidia.com id ; Fri, 03 Feb 2012 16:24:40 -0800 Received: from hqnvemgw01.nvidia.com ([172.17.108.22]) by hqnvupgp06.nvidia.com (PGP Universal service); Fri, 03 Feb 2012 16:10:20 -0800 X-PGP-Universal: processed; by hqnvupgp06.nvidia.com on Fri, 03 Feb 2012 16:10:20 -0800 Received: from daphne.nvidia.com (Not Verified[172.16.212.96]) by hqnvemgw01.nvidia.com with MailMarshal (v6, 7, 2, 8378) id ; Fri, 03 Feb 2012 16:10:20 -0800 Received: from localhost.localdomain (swarren-lx1.nvidia.com [10.20.204.51]) by daphne.nvidia.com (8.13.8+Sun/8.8.8) with ESMTP id q140AJOD012712; Fri, 3 Feb 2012 16:10:20 -0800 (PST) From: Stephen Warren To: Ben Dooks , Wolfram Sang Cc: linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, Alok Chauhan , Stephen Warren Subject: [PATCH 2/2] i2c: tegra: Remove unnecessary write to INT_STATUS Date: Fri, 3 Feb 2012 17:10:17 -0700 Message-Id: <1328314217-16632-2-git-send-email-swarren@nvidia.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1328314217-16632-1-git-send-email-swarren@nvidia.com> References: <1328314217-16632-1-git-send-email-swarren@nvidia.com> X-NVConfidentiality: public Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org From: Alok Chauhan The write is not necessary and may cause the I2C controller to misbehave. With this fix, I2C on Tegra30 works (at least, running i2cdump repeatedly on the WM8903 on Cardhu's I2C5/DVC bus). Originally by Alok Chauhan , but S-o-b missing in our internal repo. [swarren: Reworded commit description] Signed-off-by: Stephen Warren --- drivers/i2c/busses/i2c-tegra.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index a546ede..edac27b 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -456,7 +456,6 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, int ret; tegra_i2c_flush_fifos(i2c_dev); - i2c_writel(i2c_dev, 0xFF, I2C_INT_STATUS); if (msg->len == 0) return -EINVAL;