diff mbox

[V1] mfd: tps65910: Initialize irq platform data properly

Message ID 1326898156-11293-1-git-send-email-ldewangan@nvidia.com
State Not Applicable, archived
Headers show

Commit Message

Laxman Dewangan Jan. 18, 2012, 2:49 p.m. UTC
irq_base of the tps65910 irq platform data should be
initialized with the board provided irq_base data.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
 drivers/mfd/tps65910.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Laxman Dewangan Feb. 2, 2012, 1:56 p.m. UTC | #1
On Wednesday 18 January 2012 08:19 PM, Laxman Dewangan wrote:
> irq_base of the tps65910 irq platform data should be
> initialized with the board provided irq_base data.
>
> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
> ---
>   drivers/mfd/tps65910.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
> index c1da84b..8517481 100644
> --- a/drivers/mfd/tps65910.c
> +++ b/drivers/mfd/tps65910.c
> @@ -168,7 +168,7 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
>   		goto err;
>
>   	init_data->irq = pmic_plat_data->irq;
> -	init_data->irq_base = pmic_plat_data->irq;
> +	init_data->irq_base = pmic_plat_data->irq_base;
>
>   	tps65910_gpio_init(tps65910, pmic_plat_data->gpio_base);
>
Hi Samuel,
Any feedback on this patch?

Thanks,
Laxman


--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Laxman Dewangan Feb. 19, 2012, 7:34 a.m. UTC | #2
Hi Samuel,
Can you please review this patch? Without this change, the device is 
corrupting other irq registration because it tries to register  wrong irqs.

Thanks,
Laxman

On Thursday 02 February 2012 07:26 PM, Laxman Dewangan wrote:
> On Wednesday 18 January 2012 08:19 PM, Laxman Dewangan wrote:
>> irq_base of the tps65910 irq platform data should be
>> initialized with the board provided irq_base data.
>>
>> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
>> ---
>>    drivers/mfd/tps65910.c |    2 +-
>>    1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
>> index c1da84b..8517481 100644
>> --- a/drivers/mfd/tps65910.c
>> +++ b/drivers/mfd/tps65910.c
>> @@ -168,7 +168,7 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
>>    		goto err;
>>
>>    	init_data->irq = pmic_plat_data->irq;
>> -	init_data->irq_base = pmic_plat_data->irq;
>> +	init_data->irq_base = pmic_plat_data->irq_base;
>>
>>    	tps65910_gpio_init(tps65910, pmic_plat_data->gpio_base);
>>
> Hi Samuel,
> Any feedback on this patch?
>
> Thanks,
> Laxman
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Samuel Ortiz Feb. 20, 2012, 4:45 p.m. UTC | #3
Hi Laxman,

On Wed, Jan 18, 2012 at 08:19:16PM +0530, Laxman Dewangan wrote:
> irq_base of the tps65910 irq platform data should be
> initialized with the board provided irq_base data.
Thanks, patch applied to both my for-next and for-linus branches.

Cheers,
Samuel.
Laxman Dewangan Feb. 21, 2012, 5:38 a.m. UTC | #4
Thanks Samuel for taking care.

On Monday 20 February 2012 10:15 PM, Samuel Ortiz wrote:
> Hi Laxman,
>
> On Wed, Jan 18, 2012 at 08:19:16PM +0530, Laxman Dewangan wrote:
>> irq_base of the tps65910 irq platform data should be
>> initialized with the board provided irq_base data.
> Thanks, patch applied to both my for-next and for-linus branches.
>
> Cheers,
> Samuel.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index c1da84b..8517481 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -168,7 +168,7 @@  static int tps65910_i2c_probe(struct i2c_client *i2c,
 		goto err;
 
 	init_data->irq = pmic_plat_data->irq;
-	init_data->irq_base = pmic_plat_data->irq;
+	init_data->irq_base = pmic_plat_data->irq_base;
 
 	tps65910_gpio_init(tps65910, pmic_plat_data->gpio_base);