diff mbox

[8/9] arm/tegra: seaboard: add EMC table to device tree

Message ID 1324599468-12845-9-git-send-email-olof@lixom.net
State Accepted, archived
Headers show

Commit Message

Olof Johansson Dec. 23, 2011, 12:17 a.m. UTC
Timings for the T25 version of seaboard, only one memory manufacturer
and timing table (two speeds).

Signed-off-by: Olof Johansson <olof@lixom.net>
---
 arch/arm/boot/dts/tegra-seaboard.dts |   38 ++++++++++++++++++++++++++++++++++
 1 files changed, 38 insertions(+), 0 deletions(-)

Comments

Stephen Warren Jan. 4, 2012, 11:51 p.m. UTC | #1
Olof Johansson wrote at Thursday, December 22, 2011 5:18 PM:
> Timings for the T25 version of seaboard, only one memory manufacturer
> and timing table (two speeds).

There exist Seaboards with Tegra20 rather than Tegra25. Should we:
* Rename tegra-seaboard.dts to tegra-seaboard.dtsi
* Create tegra-seaboard-t20.dts and tegra-seaboard-t25.dts which include
  tegra-seaboard.dtsi, and add the EMC tables to the Tegra25 version only?

Are the timings for true Seaboard and the Springbank variant identical?
Olof Johansson Jan. 4, 2012, 11:55 p.m. UTC | #2
On Wed, Jan 4, 2012 at 3:51 PM, Stephen Warren <swarren@nvidia.com> wrote:
> Olof Johansson wrote at Thursday, December 22, 2011 5:18 PM:
>> Timings for the T25 version of seaboard, only one memory manufacturer
>> and timing table (two speeds).
>
> There exist Seaboards with Tegra20 rather than Tegra25. Should we:
> * Rename tegra-seaboard.dts to tegra-seaboard.dtsi
> * Create tegra-seaboard-t20.dts and tegra-seaboard-t25.dts which include
>  tegra-seaboard.dtsi, and add the EMC tables to the Tegra25 version only?

Honestly, T20 seaboards are deprecated around here, we've been
replacing all we have with T25 models and keeping T20 support around
is a pain. I'd rather just ignore them if we can.

> Are the timings for true Seaboard and the Springbank variant identical?

I don't know, Springbank is a mostly nvidia-internal spin that I
haven't used much. I was of that impression though, since we have
never picked up any new specific support for it, it just runs with
seaboard code.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij Jan. 5, 2012, 12:11 a.m. UTC | #3
On Thu, Jan 5, 2012 at 12:55 AM, Olof Johansson <olof@lixom.net> wrote:
> On Wed, Jan 4, 2012 at 3:51 PM, Stephen Warren <swarren@nvidia.com> wrote:
>> Olof Johansson wrote at Thursday, December 22, 2011 5:18 PM:
>>> Timings for the T25 version of seaboard, only one memory manufacturer
>>> and timing table (two speeds).
>>
>> There exist Seaboards with Tegra20 rather than Tegra25. Should we:
>> * Rename tegra-seaboard.dts to tegra-seaboard.dtsi
>> * Create tegra-seaboard-t20.dts and tegra-seaboard-t25.dts which include
>>  tegra-seaboard.dtsi, and add the EMC tables to the Tegra25 version only?
>
> Honestly, T20 seaboards are deprecated around here, we've been
> replacing all we have with T25 models and keeping T20 support around
> is a pain. I'd rather just ignore them if we can.

It's fun how board prototype problems sping up in several similar
companies :-)

When I am confronted with similar problems I have taken the stance:

Q: is the board available outside my company esp to community
 people and other hackers who will be pissed if I screw it up?

If the answer is no, and there is no risk that anyone will blame you
for it on this mailinglist - delete it. Then handle the people that
yell at you internally and ask them to bring their board to the
junkpile.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Olof Johansson Jan. 5, 2012, 5:43 a.m. UTC | #4
On Thu, Jan 05, 2012 at 01:11:33AM +0100, Linus Walleij wrote:
> On Thu, Jan 5, 2012 at 12:55 AM, Olof Johansson <olof@lixom.net> wrote:
> > On Wed, Jan 4, 2012 at 3:51 PM, Stephen Warren <swarren@nvidia.com> wrote:
> >> Olof Johansson wrote at Thursday, December 22, 2011 5:18 PM:
> >>> Timings for the T25 version of seaboard, only one memory manufacturer
> >>> and timing table (two speeds).
> >>
> >> There exist Seaboards with Tegra20 rather than Tegra25. Should we:
> >> * Rename tegra-seaboard.dts to tegra-seaboard.dtsi
> >> * Create tegra-seaboard-t20.dts and tegra-seaboard-t25.dts which include
> >>  tegra-seaboard.dtsi, and add the EMC tables to the Tegra25 version only?
> >
> > Honestly, T20 seaboards are deprecated around here, we've been
> > replacing all we have with T25 models and keeping T20 support around
> > is a pain. I'd rather just ignore them if we can.
> 
> It's fun how board prototype problems sping up in several similar
> companies :-)
> 
> When I am confronted with similar problems I have taken the stance:
> 
> Q: is the board available outside my company esp to community
>  people and other hackers who will be pissed if I screw it up?
> 
> If the answer is no, and there is no risk that anyone will blame you
> for it on this mailinglist - delete it. Then handle the people that
> yell at you internally and ask them to bring their board to the
> junkpile.

Yeah, it's normally the way to do these things, with a transition
while the supply of newer hardware is still limited. It's a little more
complicated by the fact that I personally don't have control over what
Nvidia chooses to do internally. :)


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/tegra-seaboard.dts b/arch/arm/boot/dts/tegra-seaboard.dts
index b55a02e..7ccf67e 100644
--- a/arch/arm/boot/dts/tegra-seaboard.dts
+++ b/arch/arm/boot/dts/tegra-seaboard.dts
@@ -93,4 +93,42 @@ 
 			gpio-key,wakeup;
 		};
 	};
+
+	emc@7000f400 {
+		emc-table@190000 {
+			reg = < 190000 >;
+			compatible = "nvidia,tegra20-emc-table";
+			clock-frequency = < 190000 >;
+			nvidia,emc-registers = < 0x0000000c 0x00000026
+				0x00000009 0x00000003 0x00000004 0x00000004
+				0x00000002 0x0000000c 0x00000003 0x00000003
+				0x00000002 0x00000001 0x00000004 0x00000005
+				0x00000004 0x00000009 0x0000000d 0x0000059f
+				0x00000000 0x00000003 0x00000003 0x00000003
+				0x00000003 0x00000001 0x0000000b 0x000000c8
+				0x00000003 0x00000007 0x00000004 0x0000000f
+				0x00000002 0x00000000 0x00000000 0x00000002
+				0x00000000 0x00000000 0x00000083 0xa06204ae
+				0x007dc010 0x00000000 0x00000000 0x00000000
+				0x00000000 0x00000000 0x00000000 0x00000000 >;
+		};
+
+		emc-table@380000 {
+			reg = < 380000 >;
+			compatible = "nvidia,tegra20-emc-table";
+			clock-frequency = < 380000 >;
+			nvidia,emc-registers = < 0x00000017 0x0000004b
+				0x00000012 0x00000006 0x00000004 0x00000005
+				0x00000003 0x0000000c 0x00000006 0x00000006
+				0x00000003 0x00000001 0x00000004 0x00000005
+				0x00000004 0x00000009 0x0000000d 0x00000b5f
+				0x00000000 0x00000003 0x00000003 0x00000006
+				0x00000006 0x00000001 0x00000011 0x000000c8
+				0x00000003 0x0000000e 0x00000007 0x0000000f
+				0x00000002 0x00000000 0x00000000 0x00000002
+				0x00000000 0x00000000 0x00000083 0xe044048b
+				0x007d8010 0x00000000 0x00000000 0x00000000
+				0x00000000 0x00000000 0x00000000 0x00000000 >;
+		};
+	};
 };