diff mbox series

firmware: tegra: bpmp: Return directly after a failed kzalloc() in get_filename()

Message ID 07ca2474-560f-4cbb-9740-db987227416a@web.de
State Accepted
Headers show
Series firmware: tegra: bpmp: Return directly after a failed kzalloc() in get_filename() | expand

Commit Message

Markus Elfring Dec. 25, 2023, 7:18 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 25 Dec 2023 20:03:56 +0100

The kfree() function was called in one case by
the get_filename() function during error handling
even if the passed variable contained a null pointer.
This issue was detected by using the Coccinelle software.

Thus return directly after a call of the function “kzalloc” failed
at the beginning.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/firmware/tegra/bpmp-debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.43.0

Comments

Thierry Reding Feb. 21, 2024, 4:21 p.m. UTC | #1 
From: Thierry Reding <treding@nvidia.com>


On Mon, 25 Dec 2023 20:18:44 +0100, Markus Elfring wrote:
> The kfree() function was called in one case by
> the get_filename() function during error handling
> even if the passed variable contained a null pointer.
> This issue was detected by using the Coccinelle software.
> 
> Thus return directly after a call of the function “kzalloc” failed
> at the beginning.
> 
> [...]

Applied, thanks!

[1/1] firmware: tegra: bpmp: Return directly after a failed kzalloc() in get_filename()
      commit: 1315848f1f8a0100cb6f8a7187bc320c5d98947f

Best regards,
diff mbox series

Patch

diff --git a/drivers/firmware/tegra/bpmp-debugfs.c b/drivers/firmware/tegra/bpmp-debugfs.c
index bbcdd9fed3fb..4221fed70ad4 100644
--- a/drivers/firmware/tegra/bpmp-debugfs.c
+++ b/drivers/firmware/tegra/bpmp-debugfs.c
@@ -77,7 +77,7 @@  static const char *get_filename(struct tegra_bpmp *bpmp,

 	root_path_buf = kzalloc(root_path_buf_len, GFP_KERNEL);
 	if (!root_path_buf)
-		goto out;
+		return NULL;

 	root_path = dentry_path(bpmp->debugfs_mirror, root_path_buf,
 				root_path_buf_len);