| Message ID | 20200320205504.30466-1-digetx@gmail.com |
|---|---|
| Headers | show |
| Series | Support built-in Mic on Tegra boards that use WM8903 | expand |
On 3/20/20 2:55 PM, Dmitry Osipenko wrote: > Hello, > > This small series adds audio route for built-in microphone on NVIDIA Tegra > boards that use WM8903 CODEC. In particular this is needed in order to unmute > internal microphone on Acer A500 tablet device. I'm planning to send out the > device tree for the A500 for 5.8, so will be nice to get the microphone > sorted out. Please review and apply, thanks in advance. It's been a long time since I looked at this code, but the series looks plausible, Acked-by: Stephen Warren <swarren@nvidia.com> (I wonder why machine->gpio_int_mic_en was already parse but never used!)
21.03.2020 01:30, Stephen Warren пишет: > On 3/20/20 2:55 PM, Dmitry Osipenko wrote: >> Hello, >> >> This small series adds audio route for built-in microphone on NVIDIA Tegra >> boards that use WM8903 CODEC. In particular this is needed in order to unmute >> internal microphone on Acer A500 tablet device. I'm planning to send out the >> device tree for the A500 for 5.8, so will be nice to get the microphone >> sorted out. Please review and apply, thanks in advance. > > It's been a long time since I looked at this code, but the series looks > plausible, > Acked-by: Stephen Warren <swarren@nvidia.com> Thank you! > (I wonder why machine->gpio_int_mic_en was already parse but never used!) Perhaps there were plans to support it later on, but that never materialized.
On 20/03/2020 22:30, Stephen Warren wrote: > On 3/20/20 2:55 PM, Dmitry Osipenko wrote: >> Hello, >> >> This small series adds audio route for built-in microphone on NVIDIA Tegra >> boards that use WM8903 CODEC. In particular this is needed in order to unmute >> internal microphone on Acer A500 tablet device. I'm planning to send out the >> device tree for the A500 for 5.8, so will be nice to get the microphone >> sorted out. Please review and apply, thanks in advance. > > It's been a long time since I looked at this code, but the series looks > plausible, > Acked-by: Stephen Warren <swarren@nvidia.com> > > (I wonder why machine->gpio_int_mic_en was already parse but never used!) Looking at the ventana schematics, it appears that the internal-mic signals was connected to a header and not an actual mic, so maybe we never had a proper internal-mic on any board but allowed one to be connected. Anyway, looks good to me as well. Acked-by: Jon Hunter <jonathanh@nvidia.com> Cheers Jon
23.03.2020 18:59, Jon Hunter пишет: > > > On 20/03/2020 22:30, Stephen Warren wrote: >> On 3/20/20 2:55 PM, Dmitry Osipenko wrote: >>> Hello, >>> >>> This small series adds audio route for built-in microphone on NVIDIA Tegra >>> boards that use WM8903 CODEC. In particular this is needed in order to unmute >>> internal microphone on Acer A500 tablet device. I'm planning to send out the >>> device tree for the A500 for 5.8, so will be nice to get the microphone >>> sorted out. Please review and apply, thanks in advance. >> >> It's been a long time since I looked at this code, but the series looks >> plausible, >> Acked-by: Stephen Warren <swarren@nvidia.com> >> >> (I wonder why machine->gpio_int_mic_en was already parse but never used!) > > Looking at the ventana schematics, it appears that the internal-mic > signals was connected to a header and not an actual mic, so maybe we > never had a proper internal-mic on any board but allowed one to be > connected. I guess cardhu may have a mic, judging by downstream kernel sources (I don't have cardhu schematics). > Anyway, looks good to me as well. > > Acked-by: Jon Hunter <jonathanh@nvidia.com> Thanks
Hello, This small series adds audio route for built-in microphone on NVIDIA Tegra boards that use WM8903 CODEC. In particular this is needed in order to unmute internal microphone on Acer A500 tablet device. I'm planning to send out the device tree for the A500 for 5.8, so will be nice to get the microphone sorted out. Please review and apply, thanks in advance. Dmitry Osipenko (2): dt-bindings: sound: tegra-wm8903: Document built-in microphone audio source ASoC: tegra: tegra_wm8903: Support DAPM events for built-in microphone .../sound/nvidia,tegra-audio-wm8903.txt | 1 + sound/soc/tegra/tegra_wm8903.c | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+)