mbox series

[v3,0/6] Miscellaneous improvements to Host1x and TegraDRM

Message ID 20170928125044.32516-1-mperttunen@nvidia.com
Headers show
Series Miscellaneous improvements to Host1x and TegraDRM | expand

Message

Mikko Perttunen Sept. 28, 2017, 12:50 p.m. UTC
New in v3:
- Renamed *syncpt_assign_channel to *syncpt_assign_to_channel
- Disassembler ignores opcodes not supported on the particular
  chip
- Further cleanup in u64_to_user_ptr patch

New in v2:
- Changes in syncpoint protection and u64_to_user_ptr patches.
  See the patches for notes.
- Added patch to support more opcodes in the debug dump
  disassembly.
- Added patch to fix an incorrect comment.

Thanks,
Mikko

Patch v1 notes:

Hi all,

here are some new features and improvements.

Patch 1 enables syncpoint protection which prevents channels from
touching syncpoints not belonging to them on Tegra186.

Patch 2 enables the gather filter which prevents userspace command
buffers from using CDMA commands usually reserved for the kernel.
A test is available at git://github.com/cyndis/host1x_test, branch
gather-filter.

Patch 3 greatly improves formatting of debug dumps spewed by host1x
in case of job timeouts. They are now actually readable by humans
without use of additional scripts.

Patch 4 is a simple aesthetical fix to the TegraDRM submit path.

Everything was tested on TX1 and TX2 and should be applied on the
previously posted Tegra186 support series.

Cheers,
Mikko


Mikko Perttunen (6):
  gpu: host1x: Enable Tegra186 syncpoint protection
  gpu: host1x: Enable gather filter
  gpu: host1x: Improve debug disassembly formatting
  gpu: host1x: Disassemble more instructions
  gpu: host1x: Fix incorrect comment for channel_request
  drm/tegra: Use u64_to_user_ptr helper

 drivers/gpu/drm/tegra/drm.c                 |  29 ++++----
 drivers/gpu/host1x/channel.c                |   3 +-
 drivers/gpu/host1x/debug.c                  |  14 +++-
 drivers/gpu/host1x/debug.h                  |  14 ++--
 drivers/gpu/host1x/dev.h                    |  15 ++++
 drivers/gpu/host1x/hw/channel_hw.c          |  25 +++++++
 drivers/gpu/host1x/hw/debug_hw.c            | 103 ++++++++++++++++++++++------
 drivers/gpu/host1x/hw/debug_hw_1x01.c       |  10 +--
 drivers/gpu/host1x/hw/debug_hw_1x06.c       |  12 ++--
 drivers/gpu/host1x/hw/hw_host1x04_channel.h |  12 ++++
 drivers/gpu/host1x/hw/hw_host1x05_channel.h |  12 ++++
 drivers/gpu/host1x/hw/syncpt_hw.c           |  46 +++++++++++++
 drivers/gpu/host1x/syncpt.c                 |   8 +++
 13 files changed, 252 insertions(+), 51 deletions(-)

Comments

Thierry Reding Oct. 19, 2017, noon UTC | #1
On Thu, Sep 28, 2017 at 03:50:38PM +0300, Mikko Perttunen wrote:
> New in v3:
> - Renamed *syncpt_assign_channel to *syncpt_assign_to_channel
> - Disassembler ignores opcodes not supported on the particular
>   chip
> - Further cleanup in u64_to_user_ptr patch
> 
> New in v2:
> - Changes in syncpoint protection and u64_to_user_ptr patches.
>   See the patches for notes.
> - Added patch to support more opcodes in the debug dump
>   disassembly.
> - Added patch to fix an incorrect comment.
> 
> Thanks,
> Mikko
> 
> Patch v1 notes:
> 
> Hi all,
> 
> here are some new features and improvements.
> 
> Patch 1 enables syncpoint protection which prevents channels from
> touching syncpoints not belonging to them on Tegra186.
> 
> Patch 2 enables the gather filter which prevents userspace command
> buffers from using CDMA commands usually reserved for the kernel.
> A test is available at git://github.com/cyndis/host1x_test, branch
> gather-filter.
> 
> Patch 3 greatly improves formatting of debug dumps spewed by host1x
> in case of job timeouts. They are now actually readable by humans
> without use of additional scripts.
> 
> Patch 4 is a simple aesthetical fix to the TegraDRM submit path.
> 
> Everything was tested on TX1 and TX2 and should be applied on the
> previously posted Tegra186 support series.
> 
> Cheers,
> Mikko
> 
> 
> Mikko Perttunen (6):
>   gpu: host1x: Enable Tegra186 syncpoint protection
>   gpu: host1x: Enable gather filter
>   gpu: host1x: Improve debug disassembly formatting
>   gpu: host1x: Disassemble more instructions
>   gpu: host1x: Fix incorrect comment for channel_request
>   drm/tegra: Use u64_to_user_ptr helper
> 
>  drivers/gpu/drm/tegra/drm.c                 |  29 ++++----
>  drivers/gpu/host1x/channel.c                |   3 +-
>  drivers/gpu/host1x/debug.c                  |  14 +++-
>  drivers/gpu/host1x/debug.h                  |  14 ++--
>  drivers/gpu/host1x/dev.h                    |  15 ++++
>  drivers/gpu/host1x/hw/channel_hw.c          |  25 +++++++
>  drivers/gpu/host1x/hw/debug_hw.c            | 103 ++++++++++++++++++++++------
>  drivers/gpu/host1x/hw/debug_hw_1x01.c       |  10 +--
>  drivers/gpu/host1x/hw/debug_hw_1x06.c       |  12 ++--
>  drivers/gpu/host1x/hw/hw_host1x04_channel.h |  12 ++++
>  drivers/gpu/host1x/hw/hw_host1x05_channel.h |  12 ++++
>  drivers/gpu/host1x/hw/syncpt_hw.c           |  46 +++++++++++++
>  drivers/gpu/host1x/syncpt.c                 |   8 +++
>  13 files changed, 252 insertions(+), 51 deletions(-)

Applied, thanks.

Thierry