| Message ID | 1637219231-406-1-git-send-email-spujar@nvidia.com |
|---|---|
| Headers | show |
| Series | Kcontrol get/put cleanup in Tegra drivers | expand |
On Thu, 18 Nov 2021 08:06:55 +0100, Sameer Pujar wrote: > > There are two cleanups in the series: > 1. Use correct value type for enum controls. This is suggested by > Takashi during review of v2. > > 2. This series fixes kcontrol put callback in some of the Tegra drivers > which are used on platforms based on Tegra210 and later. The callback > is expected to return 1 whenever the HW update is done. > > This idea is suggested by Jaroslav. Similar suggestion came from > Mark during review of series [0] and drivers under this were updated > to return 1, but missed to take care of duplicate updates. This series > updates all concerned drivers to return proper values and duplicate > updates are filtered out. > > I have added 'Suggested-by" tags accordingly. > > [0] https://lore.kernel.org/linux-arm-kernel/20210913142307.GF4283@sirena.org.uk/ > > Changelog > ========= > v2->v3: > ------- > * Add fixes related to wrong value type as suggested by Takashi. > Relevant drivers are updated as part of it. > > * Use separate get/put callbacks for each mixer control. The common > part is pushed to separate function wherever applicable, thus > removing usage of strstr() calls. The return values are fixed > as suggested. > > > v1->v2: > ------- > * ADMAIF, I2S, DMIC and DSPK drivers updated to take care of > duplicate updates. > * Similarly new patches are added for AHUB, MVC, SFC, AMX, ADX > and Mixer drivers. > > Sameer Pujar (16): > ASoC: tegra: Fix wrong value type in ADMAIF > ASoC: tegra: Fix wrong value type in I2S > ASoC: tegra: Fix wrong value type in DMIC > ASoC: tegra: Fix wrong value type in DSPK > ASoC: tegra: Fix wrong value type in SFC > ASoC: tegra: Fix wrong value type in MVC > ASoC: tegra: Fix kcontrol put callback in ADMAIF > ASoC: tegra: Fix kcontrol put callback in I2S > ASoC: tegra: Fix kcontrol put callback in DMIC > ASoC: tegra: Fix kcontrol put callback in DSPK > ASoC: tegra: Fix kcontrol put callback in AHUB > ASoC: tegra: Fix kcontrol put callback in MVC > ASoC: tegra: Fix kcontrol put callback in SFC > ASoC: tegra: Fix kcontrol put callback in AMX > ASoC: tegra: Fix kcontrol put callback in ADX > ASoC: tegra: Fix kcontrol put callback in Mixer Through a quick glance, the series looks good to me. One place could be more optimized with a regmap helper, but it's a minor issue and can be updated later, too. Reviewed-by: Takashi Iwai <tiwai@suse.de> thanks, Takashi
On Thu, 18 Nov 2021 12:36:55 +0530, Sameer Pujar wrote: > There are two cleanups in the series: > 1. Use correct value type for enum controls. This is suggested by > Takashi during review of v2. > > 2. This series fixes kcontrol put callback in some of the Tegra drivers > which are used on platforms based on Tegra210 and later. The callback > is expected to return 1 whenever the HW update is done. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-linus Thanks! [01/16] ASoC: tegra: Fix wrong value type in ADMAIF commit: 884c6cb3b7030f75c46e55b9e625d2372708c306 [02/16] ASoC: tegra: Fix wrong value type in I2S commit: 8a2c2fa0c5331445c801e9241f2bb4e0e2a895a8 [03/16] ASoC: tegra: Fix wrong value type in DMIC commit: 559d234569a998a4004de1bd1f12da5487fb826e [04/16] ASoC: tegra: Fix wrong value type in DSPK commit: 3aa0d5c8bb3f5ef622ec2764823f551a1f630711 [05/16] ASoC: tegra: Fix wrong value type in SFC commit: 42afca1a65661935cdd54d2e0c5d0cc2426db7af [06/16] ASoC: tegra: Fix wrong value type in MVC commit: 6762965d0214df474e3a58e1d4d3ab004c5da0ea [07/16] ASoC: tegra: Fix kcontrol put callback in ADMAIF commit: e2b87a18a60c02d0dcd1de801d669587e516cc4d [08/16] ASoC: tegra: Fix kcontrol put callback in I2S commit: f21a9df3f7cb0005947679d7b9237c90574e229a [09/16] ASoC: tegra: Fix kcontrol put callback in DMIC commit: a347dfa10262fa0a10e2b1970ea0194e3d4a3251 [10/16] ASoC: tegra: Fix kcontrol put callback in DSPK commit: d6202a57e79d102271d38c34481fedc9d4c79694 [11/16] ASoC: tegra: Fix kcontrol put callback in AHUB commit: a4e37950c9e9b126f9cbee79b8ab94a94646dcf1 [12/16] ASoC: tegra: Fix kcontrol put callback in MVC commit: c7b34b51bbac6ab64e873f6c9bd43564a7442e33 [13/16] ASoC: tegra: Fix kcontrol put callback in SFC commit: b31f8febd1850bbe74aba184779ec54552d92752 [14/16] ASoC: tegra: Fix kcontrol put callback in AMX commit: 8db78ace1ba897302131422ce15c5eb04510cef8 [15/16] ASoC: tegra: Fix kcontrol put callback in ADX commit: 3c97881b8c8a2aa8afd4d7a379b7ff03884c9e4a [16/16] ASoC: tegra: Fix kcontrol put callback in Mixer commit: 8cf72c4e75a0265135d34a8e29224b4c1e92b51c All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
There are two cleanups in the series: 1. Use correct value type for enum controls. This is suggested by Takashi during review of v2. 2. This series fixes kcontrol put callback in some of the Tegra drivers which are used on platforms based on Tegra210 and later. The callback is expected to return 1 whenever the HW update is done. This idea is suggested by Jaroslav. Similar suggestion came from Mark during review of series [0] and drivers under this were updated to return 1, but missed to take care of duplicate updates. This series updates all concerned drivers to return proper values and duplicate updates are filtered out. I have added 'Suggested-by" tags accordingly. [0] https://lore.kernel.org/linux-arm-kernel/20210913142307.GF4283@sirena.org.uk/ Changelog ========= v2->v3: ------- * Add fixes related to wrong value type as suggested by Takashi. Relevant drivers are updated as part of it. * Use separate get/put callbacks for each mixer control. The common part is pushed to separate function wherever applicable, thus removing usage of strstr() calls. The return values are fixed as suggested. v1->v2: ------- * ADMAIF, I2S, DMIC and DSPK drivers updated to take care of duplicate updates. * Similarly new patches are added for AHUB, MVC, SFC, AMX, ADX and Mixer drivers. Sameer Pujar (16): ASoC: tegra: Fix wrong value type in ADMAIF ASoC: tegra: Fix wrong value type in I2S ASoC: tegra: Fix wrong value type in DMIC ASoC: tegra: Fix wrong value type in DSPK ASoC: tegra: Fix wrong value type in SFC ASoC: tegra: Fix wrong value type in MVC ASoC: tegra: Fix kcontrol put callback in ADMAIF ASoC: tegra: Fix kcontrol put callback in I2S ASoC: tegra: Fix kcontrol put callback in DMIC ASoC: tegra: Fix kcontrol put callback in DSPK ASoC: tegra: Fix kcontrol put callback in AHUB ASoC: tegra: Fix kcontrol put callback in MVC ASoC: tegra: Fix kcontrol put callback in SFC ASoC: tegra: Fix kcontrol put callback in AMX ASoC: tegra: Fix kcontrol put callback in ADX ASoC: tegra: Fix kcontrol put callback in Mixer sound/soc/tegra/tegra186_dspk.c | 181 ++++++++++++++++++----- sound/soc/tegra/tegra210_admaif.c | 140 ++++++++++++++---- sound/soc/tegra/tegra210_adx.c | 3 + sound/soc/tegra/tegra210_ahub.c | 11 +- sound/soc/tegra/tegra210_amx.c | 3 + sound/soc/tegra/tegra210_dmic.c | 184 +++++++++++++++++++----- sound/soc/tegra/tegra210_i2s.c | 296 +++++++++++++++++++++++++++++--------- sound/soc/tegra/tegra210_mixer.c | 26 +++- sound/soc/tegra/tegra210_mvc.c | 30 ++-- sound/soc/tegra/tegra210_sfc.c | 123 ++++++++++++---- 10 files changed, 780 insertions(+), 217 deletions(-)