| Message ID | 1575600535-26877-1-git-send-email-skomatineni@nvidia.com |
|---|---|
| Headers | show |
| Series | Move PMC clocks into Tegra PMC driver | expand |
06.12.2019 05:48, Sowjanya Komatineni пишет: > Tegra PMC has clk_out_1, clk_out_2, clk_out_3 and blink controls which > are currently registered by Tegra clock driver using clk_regiser_mux and > clk_register_gate which performs direct Tegra PMC register access. > > When Tegra PMC is in secure mode, any access from non-secure world will > not go through. > > This patch series adds these Tegra PMC clocks and blink controls to Tegra > PMC driver with PMC as clock provider and removed them from Tegra clock > driver. This also adds PMC specific clock id's to use in device tree and > removed clock ids of PMC clock from Tegra clock driver. > > clk_out_1 is dedicated for audio mclk and current ASoC driver does not > setting extern1 as parent for clk_out_1 and enabling clk_out_1 and > currently this is taken care by Tegra clock driver during clock inits > and there is no need to enable this during clock init. > > So, this series also includes patch that updates ASoC driver to take > care of configuring parent of mclk and enabling mclk using both extern1 > and clk_out_1 and updates all device trees to use clk_out_1 from pmc as > mclk incase if device tree don't specify assigned-clock-parents. > > This series also includes a patch for mclk fallback to use extern1 > when retrieving mclk fails with new device tree which uses pmc provider > to have this backward compatible of new DT with old kernels. > > This series also includes a patch to remove clock ids for these clocks > from clock dt-binding as these clocks are not used in any of the existing > device tree except in tegra210-smaug.dts and this series includes a patch > to update clock provider from tegra_car to pmc in tegra210-smaug.dts for > clk_out_2. > > [v3]: Changes between v2 and v3 are > - Removes set parent of clk_out_1_mux to extern1 and enabling > extern1 from the clock driver. > - Doesn't enable clk_out_1 and blink by default in pmc driver > - Updates ASoC driver to take care of audio mclk parent > configuration incase if device tree don't specify assigned > clock parent properties and enables mclk using both clk_out_1 > and extern1. > - updates all device trees using extern1 as mclk in sound node > to use clk_out_1 from pmc. > - patch for YAML format pmc dt-binding > - Includes v2 feedback > > [v2]: Changes between v1 and v2 are > - v2 includes patches for adding clk_out_1, clk_out_2, clk_out_3, > blink controls to Tegra PMC driver and removing clk-tegra-pmc. > - feedback related to pmc clocks in Tegra PMC driver from v1 > - Removed patches for WB0 PLLM overrides and PLLE IDDQ PMC programming > by the clock driver using helper functions from Tegra PMC. > > Note: > To use helper functions from PMC driver, PMC early init need to > happen prior to using helper functions and these helper functions are > for PLLM Override and PLLE IDDQ programming in PMC during PLLM/PLLE > clock registration which happen in clock_init prior to Tegra PMC > probe. > Moving PLLM/PLLE clocks registration to happen after Tegra PMC > impacts other clocks EMC, MC and corresponding tegra_emc_init and > tegra_mc_init. > This implementation of configuring PMC registers thru helper > functions in clock driver needs proper changes across PMC, Clock, > EMC and MC inits to have it work across all Tegra platforms. > > Currently PLLM Override is not enabled in the bootloader so proper > patches for this fix will be taken care separately. > > [v1]: v1 includes patches for below fixes. > - adding clk_out_1, clk_out_2, clk_out_3, blink controls to Tegra PMC > driver and removing clk-tegra-pmc. > - updated clock provider from tegra_car to pmc in the device tree > tegra210-smaug.dts that uses clk_out_2. > - Added helper functions in PMC driver for WB0 PLLM overrides and PLLE > IDDQ programming to use by clock driver and updated clock driver to > use these helper functions and removed direct PMC access from clock > driver and all pmc base address references in clock driver. > > > Sowjanya Komatineni (15): > dt-bindings: soc: tegra-pmc: Add Tegra PMC clock bindings > dt-bindings: tegra: Convert Tegra PMC bindings to YAML > soc: tegra: Add Tegra PMC clock registrations into PMC driver > dt-bindings: soc: tegra-pmc: Add id for Tegra PMC blink control > soc: pmc: Add blink output clock registration to Tegra PMC > clk: tegra: Remove tegra_pmc_clk_init along with clk ids > dt-bindings: clock: tegra: Remove pmc clock ids from clock dt-bindings > ASoC: tegra: Add audio mclk control through clk_out_1 and extern1 > ASoC: tegra: Add fallback for audio mclk > clk: tegra: Remove extern1 and cdev1 from clocks inittable > ARM: dts: tegra: Add clock-cells property to pmc > arm64: tegra: Add clock-cells property to Tegra PMC node > ARM: tegra: Update sound node clocks in device tree > arm64: tegra: smaug: Change clk_out_2 provider to pmc > ASoC: nau8825: change Tegra clk_out_2 provider from tegra_car to pmc Hello Sowjanya, Something gone wrong with these patches because I didn't receive them and don't see them on the ML either. Also, the list of email correspondents looks a bit too larger. I'm pretty sure some of the people do not care much about this series. I tend to use script/get_maintainer.pl and then manually pick the relevant people for patches.
On 12/7/19 6:26 AM, Dmitry Osipenko wrote: > 06.12.2019 05:48, Sowjanya Komatineni пишет: >> Tegra PMC has clk_out_1, clk_out_2, clk_out_3 and blink controls which >> are currently registered by Tegra clock driver using clk_regiser_mux and >> clk_register_gate which performs direct Tegra PMC register access. >> >> When Tegra PMC is in secure mode, any access from non-secure world will >> not go through. >> >> This patch series adds these Tegra PMC clocks and blink controls to Tegra >> PMC driver with PMC as clock provider and removed them from Tegra clock >> driver. This also adds PMC specific clock id's to use in device tree and >> removed clock ids of PMC clock from Tegra clock driver. >> >> clk_out_1 is dedicated for audio mclk and current ASoC driver does not >> setting extern1 as parent for clk_out_1 and enabling clk_out_1 and >> currently this is taken care by Tegra clock driver during clock inits >> and there is no need to enable this during clock init. >> >> So, this series also includes patch that updates ASoC driver to take >> care of configuring parent of mclk and enabling mclk using both extern1 >> and clk_out_1 and updates all device trees to use clk_out_1 from pmc as >> mclk incase if device tree don't specify assigned-clock-parents. >> >> This series also includes a patch for mclk fallback to use extern1 >> when retrieving mclk fails with new device tree which uses pmc provider >> to have this backward compatible of new DT with old kernels. >> >> This series also includes a patch to remove clock ids for these clocks >> from clock dt-binding as these clocks are not used in any of the existing >> device tree except in tegra210-smaug.dts and this series includes a patch >> to update clock provider from tegra_car to pmc in tegra210-smaug.dts for >> clk_out_2. >> >> [v3]: Changes between v2 and v3 are >> - Removes set parent of clk_out_1_mux to extern1 and enabling >> extern1 from the clock driver. >> - Doesn't enable clk_out_1 and blink by default in pmc driver >> - Updates ASoC driver to take care of audio mclk parent >> configuration incase if device tree don't specify assigned >> clock parent properties and enables mclk using both clk_out_1 >> and extern1. >> - updates all device trees using extern1 as mclk in sound node >> to use clk_out_1 from pmc. >> - patch for YAML format pmc dt-binding >> - Includes v2 feedback >> >> [v2]: Changes between v1 and v2 are >> - v2 includes patches for adding clk_out_1, clk_out_2, clk_out_3, >> blink controls to Tegra PMC driver and removing clk-tegra-pmc. >> - feedback related to pmc clocks in Tegra PMC driver from v1 >> - Removed patches for WB0 PLLM overrides and PLLE IDDQ PMC programming >> by the clock driver using helper functions from Tegra PMC. >> >> Note: >> To use helper functions from PMC driver, PMC early init need to >> happen prior to using helper functions and these helper functions are >> for PLLM Override and PLLE IDDQ programming in PMC during PLLM/PLLE >> clock registration which happen in clock_init prior to Tegra PMC >> probe. >> Moving PLLM/PLLE clocks registration to happen after Tegra PMC >> impacts other clocks EMC, MC and corresponding tegra_emc_init and >> tegra_mc_init. >> This implementation of configuring PMC registers thru helper >> functions in clock driver needs proper changes across PMC, Clock, >> EMC and MC inits to have it work across all Tegra platforms. >> >> Currently PLLM Override is not enabled in the bootloader so proper >> patches for this fix will be taken care separately. >> >> [v1]: v1 includes patches for below fixes. >> - adding clk_out_1, clk_out_2, clk_out_3, blink controls to Tegra PMC >> driver and removing clk-tegra-pmc. >> - updated clock provider from tegra_car to pmc in the device tree >> tegra210-smaug.dts that uses clk_out_2. >> - Added helper functions in PMC driver for WB0 PLLM overrides and PLLE >> IDDQ programming to use by clock driver and updated clock driver to >> use these helper functions and removed direct PMC access from clock >> driver and all pmc base address references in clock driver. >> >> >> Sowjanya Komatineni (15): >> dt-bindings: soc: tegra-pmc: Add Tegra PMC clock bindings >> dt-bindings: tegra: Convert Tegra PMC bindings to YAML >> soc: tegra: Add Tegra PMC clock registrations into PMC driver >> dt-bindings: soc: tegra-pmc: Add id for Tegra PMC blink control >> soc: pmc: Add blink output clock registration to Tegra PMC >> clk: tegra: Remove tegra_pmc_clk_init along with clk ids >> dt-bindings: clock: tegra: Remove pmc clock ids from clock dt-bindings >> ASoC: tegra: Add audio mclk control through clk_out_1 and extern1 >> ASoC: tegra: Add fallback for audio mclk >> clk: tegra: Remove extern1 and cdev1 from clocks inittable >> ARM: dts: tegra: Add clock-cells property to pmc > >> arm64: tegra: Add clock-cells property to Tegra PMC node >> ARM: tegra: Update sound node clocks in device tree >> arm64: tegra: smaug: Change clk_out_2 provider to pmc >> ASoC: nau8825: change Tegra clk_out_2 provider from tegra_car to pmc > Hello Sowjanya, > > Something gone wrong with these patches because I didn't receive them > and don't see them on the ML either. > > Also, the list of email correspondents looks a bit too larger. I'm > pretty sure some of the people do not care much about this series. I > tend to use script/get_maintainer.pl and then manually pick the relevant > people for patches. Not sure what went wrong. I sent this series to all previous mailing list and inaddition added based on get_maintainers scripts for ASoC and device tree related. Will manually pick and reduce mailing list for next series..