From patchwork Sat May 14 10:36:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Jackson X-Patchwork-Id: 622215 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3r6NSJ1y7Qz9t62 for ; Sat, 14 May 2016 20:36:32 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=oscode-net.20150623.gappssmtp.com header.i=@oscode-net.20150623.gappssmtp.com header.b=re0lO26r; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbcENKgb (ORCPT ); Sat, 14 May 2016 06:36:31 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34959 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934AbcENKga (ORCPT ); Sat, 14 May 2016 06:36:30 -0400 Received: by mail-wm0-f68.google.com with SMTP id e201so8302488wme.2 for ; Sat, 14 May 2016 03:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oscode-net.20150623.gappssmtp.com; s=20150623; h=to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=BNZyMi+tFXMgzKGDGmHu1FKfmnGcMl16pOAMZ3Qf5ro=; b=re0lO26r/4Ze/pKrp98BuDstHcYLyxpWmeBc5jJFFPa431n/alDQfPZMkL6jPyxV1g YwC+UgYWdGXwBvr27qxgL/JarCXBSaJWwkRE8ME4OWH/oX3RVs9b4+j4y/wIgYHKWSfH jlVb7nfzJW184AMyTfA8RFrk7tD+Klw+YrKnNMQ7ckIEIpGq8aXmrFnaTErLDWdjpu3A 2KxmTY4QgkhfrSXja8xrHhioCc+BC8nHMJ07JA0vwYfu68WqFA5X5bT0aQyImpt4sn8v +LS8WWgQK6w1IIRh2c+vWnWeqPRj30XGEhMdzStu1G5ieaY/f4G3GF+7ziDHSXepNOJy CBTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=BNZyMi+tFXMgzKGDGmHu1FKfmnGcMl16pOAMZ3Qf5ro=; b=mn89TSbcTnNMwLefJO8b654l3TOPIdIQnobCYHMoavOggyq6qQw4uyRGxfq+UhQ9yS vyEpkbOutE1PyNh4Xssrk5e9A09YKPQG9DBzvFfcWYEIVXgn2evj+90AHmiGXxz6jWCn 3OgURUnvxYJEIlolhX7Anxn0pafbBAAALIVhXNFyLDowoNmJehggUPh7PFn3D6lHyTGQ QgLnQ5g+joFJkYFomfDjCInoCRfbxVoMO8UdzdRTJg5gKzdHg9wPhjTUAVePRBQrG43X sL1DDa/Vs96IXnVgi/AXuL83Wwi8eLuD0Uxj5ebp2LIq2pxBLOnuTaYDQkATXeQkKQpH H4SQ== X-Gm-Message-State: AOPr4FW2KcX+E29lMQv3IcvJ9ON+uzf4Db865j3hjjksjeLle1Uj4AEcM694+1ROrdDXaw== X-Received: by 10.28.57.137 with SMTP id g131mr8661984wma.5.1463222188595; Sat, 14 May 2016 03:36:28 -0700 (PDT) Received: from [192.168.0.3] (cpc74487-stre6-2-0-cust124.1-1.cable.virginm.net. [82.22.61.125]) by smtp.gmail.com with ESMTPSA id i1sm23008334wjd.38.2016.05.14.03.36.26 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 14 May 2016 03:36:27 -0700 (PDT) To: linux-pwm@vger.kernel.org, thierry.reding@gmail.com, jingoohan1@gmail.com From: Steven Jackson Subject: [PATCH v2] backlight: pwm_bl: use gpiod_set_value_cansleep to fix warnings Message-ID: <5736FFAA.9090402@oscode.net> Date: Sat, 14 May 2016 11:36:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org This is the same issue and fix as 1581b088fc91cbb974ad2b98431a8ecabb48 (backlight: corgi_lcd: use gpio_set_value_cansleep() to avoid WARN_ON). PWM backlights which use a SPI/I2C IO expander to control power will see warnings when disabling and enabling the backlight, we should use _cansleep variants of gpio set/get whenever the context can sleep. Other backlight drivers such as corgi_bl.c and gpio_backlight.c are using _cansleep variants in the same contexts. Signed-off-by: Steven Jackson --- drivers/video/backlight/pwm_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) pb->enabled = true; @@ -70,7 +70,7 @@ static void pwm_backlight_power_off(struct pwm_bl_data *pb) pwm_disable(pb->pwm); if (pb->enable_gpio) - gpiod_set_value(pb->enable_gpio, 0); + gpiod_set_value_cansleep(pb->enable_gpio, 0); regulator_disable(pb->power_supply); pb->enabled = false; diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index b2b366b..1261400 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c @@ -55,7 +55,7 @@ static void pwm_backlight_power_on(struct pwm_bl_data *pb, int brightness) dev_err(pb->dev, "failed to enable power supply\n"); if (pb->enable_gpio) - gpiod_set_value(pb->enable_gpio, 1); + gpiod_set_value_cansleep(pb->enable_gpio, 1); pwm_enable(pb->pwm);