| Message ID | 4a3acf8673c08308848fb7ae73d992b6feb758d3.1587523702.git.gurus@codeaurora.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v13,01/11] drm/i915: Use 64-bit division macro | expand |
On Tue, 21 Apr 2020, Guru Das Srinagesh <gurus@codeaurora.org> wrote: > Since the PWM framework is switching struct pwm_state.duty_cycle's > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL > to handle a 64-bit dividend. > > To: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com> > Cc: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Superfluous blank line. Anyway, please preserve the existing acks and reviews [1] so people don't have to do it again. BR, Jani. [1] http://lore.kernel.org/r/87h7yleb0i.fsf@intel.com > Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org> > --- > drivers/gpu/drm/i915/display/intel_panel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c > index 276f438..81547a0 100644 > --- a/drivers/gpu/drm/i915/display/intel_panel.c > +++ b/drivers/gpu/drm/i915/display/intel_panel.c > @@ -1920,7 +1920,7 @@ static int pwm_setup_backlight(struct intel_connector *connector, > return retval; > } > > - level = DIV_ROUND_UP(pwm_get_duty_cycle(panel->backlight.pwm) * 100, > + level = DIV_ROUND_UP_ULL(pwm_get_duty_cycle(panel->backlight.pwm) * 100, > CRC_PMIC_PWM_PERIOD_NS); > panel->backlight.level = > intel_panel_compute_brightness(connector, level);
On Fri, Apr 24, 2020 at 09:17:58AM +0300, Jani Nikula wrote: > On Tue, 21 Apr 2020, Guru Das Srinagesh <gurus@codeaurora.org> wrote: > > Since the PWM framework is switching struct pwm_state.duty_cycle's > > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL > > to handle a 64-bit dividend. > > > > To: Jani Nikula <jani.nikula@linux.intel.com> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com> > > Cc: intel-gfx@lists.freedesktop.org > > Cc: dri-devel@lists.freedesktop.org > > > > Superfluous blank line. Will remove. > > Anyway, please preserve the existing acks and reviews [1] so people > don't have to do it again. > > BR, > Jani. > > [1] http://lore.kernel.org/r/87h7yleb0i.fsf@intel.com I dropped your Acked-by as the patch had to changed to resolve a merge conflict when I rebased to tip. Could you please re-review this patch? Thank you. Guru Das.
On Fri, 24 Apr 2020, Guru Das Srinagesh <gurus@codeaurora.org> wrote: > On Fri, Apr 24, 2020 at 09:17:58AM +0300, Jani Nikula wrote: >> On Tue, 21 Apr 2020, Guru Das Srinagesh <gurus@codeaurora.org> wrote: >> > Since the PWM framework is switching struct pwm_state.duty_cycle's >> > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL >> > to handle a 64-bit dividend. >> > >> > To: Jani Nikula <jani.nikula@linux.intel.com> >> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> >> > Cc: David Airlie <airlied@linux.ie> >> > Cc: Daniel Vetter <daniel@ffwll.ch> >> > Cc: Chris Wilson <chris@chris-wilson.co.uk> >> > Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com> >> > Cc: intel-gfx@lists.freedesktop.org >> > Cc: dri-devel@lists.freedesktop.org >> > >> >> Superfluous blank line. > > Will remove. > >> >> Anyway, please preserve the existing acks and reviews [1] so people >> don't have to do it again. >> >> BR, >> Jani. >> >> [1] http://lore.kernel.org/r/87h7yleb0i.fsf@intel.com > > I dropped your Acked-by as the patch had to changed to resolve a merge > conflict when I rebased to tip. Could you please re-review this patch? Reviewed-by: Jani Nikula <jani.nikula@intel.com> Acked-by: Jani Nikula <jani.nikula@intel.com>
diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c index 276f438..81547a0 100644 --- a/drivers/gpu/drm/i915/display/intel_panel.c +++ b/drivers/gpu/drm/i915/display/intel_panel.c @@ -1920,7 +1920,7 @@ static int pwm_setup_backlight(struct intel_connector *connector, return retval; } - level = DIV_ROUND_UP(pwm_get_duty_cycle(panel->backlight.pwm) * 100, + level = DIV_ROUND_UP_ULL(pwm_get_duty_cycle(panel->backlight.pwm) * 100, CRC_PMIC_PWM_PERIOD_NS); panel->backlight.level = intel_panel_compute_brightness(connector, level);
Since the PWM framework is switching struct pwm_state.duty_cycle's datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL to handle a 64-bit dividend. To: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com> Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org> --- drivers/gpu/drm/i915/display/intel_panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)